[
https://issues.apache.org/jira/browse/BEAM-3326?focusedWorklogId=92772&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-92772
]
ASF GitHub Bot logged work on BEAM-3326:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Apr/18 18:29
Start Date: 19/Apr/18 18:29
Worklog Time Spent: 10m
Work Description: tgroh closed pull request #4761: [BEAM-3326] Remove
SdkHarnessClientControlService
URL: https://github.com/apache/beam/pull/4761
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/control/SdkHarnessClientControlService.java
b/runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/control/SdkHarnessClientControlService.java
deleted file mode 100644
index 3f1d14809c9..00000000000
---
a/runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/control/SdkHarnessClientControlService.java
+++ /dev/null
@@ -1,80 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package org.apache.beam.runners.fnexecution.control;
-
-import io.grpc.ServerServiceDefinition;
-import java.util.Collection;
-import java.util.concurrent.ConcurrentLinkedQueue;
-import java.util.function.Supplier;
-import org.apache.beam.runners.fnexecution.FnService;
-import org.apache.beam.runners.fnexecution.HeaderAccessor;
-import org.apache.beam.runners.fnexecution.data.FnDataService;
-
-/**
- * A service providing {@link SdkHarnessClient} based on an internally managed
{@link
- * FnApiControlClientPoolService}.
- */
-public class SdkHarnessClientControlService implements FnService {
- private final FnApiControlClientPoolService clientPoolService;
- private final ControlClientPool<FnApiControlClient> pendingClients;
-
- private final Supplier<FnDataService> dataService;
-
- private final Collection<SdkHarnessClient> activeClients;
-
- public static SdkHarnessClientControlService create(
- Supplier<FnDataService> dataService, HeaderAccessor headerAccessor) {
- return new SdkHarnessClientControlService(dataService, headerAccessor);
- }
-
- private SdkHarnessClientControlService(
- Supplier<FnDataService> dataService, HeaderAccessor headerAccessor) {
- this.dataService = dataService;
- activeClients = new ConcurrentLinkedQueue<>();
- pendingClients = QueueControlClientPool.createSynchronous();
- clientPoolService =
-
FnApiControlClientPoolService.offeringClientsToPool(pendingClients.getSink(),
- headerAccessor);
- }
-
- public SdkHarnessClient getClient() {
- try {
- // Block until a client is available.
- FnApiControlClient getClient = pendingClients.getSource().get();
- return SdkHarnessClient.usingFnApiClient(getClient, dataService.get());
- } catch (InterruptedException e) {
- Thread.currentThread().interrupt();
- throw new RuntimeException("Interrupted while waiting for client", e);
- } catch (Exception e) {
- throw new RuntimeException(e);
- }
- }
-
- @Override
- public void close() throws Exception {
- for (SdkHarnessClient client : activeClients) {
- client.close();
- }
- }
-
- @Override
- public ServerServiceDefinition bindService() {
- return clientPoolService.bindService();
- }
-}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 92772)
Time Spent: 6.5h (was: 6h 20m)
> Execute a Stage via the portability framework in the ReferenceRunner
> --------------------------------------------------------------------
>
> Key: BEAM-3326
> URL: https://issues.apache.org/jira/browse/BEAM-3326
> Project: Beam
> Issue Type: New Feature
> Components: runner-core
> Reporter: Thomas Groh
> Assignee: Thomas Groh
> Priority: Major
> Labels: portability
> Time Spent: 6.5h
> Remaining Estimate: 0h
>
> This is the supertask for remote execution in the Universal Local Runner
> (BEAM-2899).
> This executes a stage remotely via portability framework APIs
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
