[
https://issues.apache.org/jira/browse/BEAM-3812?focusedWorklogId=92931&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-92931
]
ASF GitHub Bot logged work on BEAM-3812:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Apr/18 23:42
Start Date: 19/Apr/18 23:42
Worklog Time Spent: 10m
Work Description: chamikaramj commented on a change in pull request
#5174: [BEAM-3812] Avoid pickling composite transforms.
URL: https://github.com/apache/beam/pull/5174#discussion_r182846932
##########
File path: sdks/python/apache_beam/io/gcp/pubsub.py
##########
@@ -152,6 +152,11 @@ def expand(self, pvalue):
pcoll.element_type = bytes
return pcoll
+ def to_runner_api_parameter(self, context):
+ # Required as this is identified by type in PTransformOverrides.
+ # TODO(BEAM-3812): Use an actual URN here.
Review comment:
Should this be a different JIRA ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 92931)
Time Spent: 20m (was: 10m)
> Avoid pickling PTransforms in proto representation
> --------------------------------------------------
>
> Key: BEAM-3812
> URL: https://issues.apache.org/jira/browse/BEAM-3812
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Robert Bradshaw
> Assignee: Ahmet Altay
> Priority: Minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Any transform that requires passing information through the runner protos
> should have an explicit urn and payload.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
