[
https://issues.apache.org/jira/browse/BEAM-3327?focusedWorklogId=93506&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-93506
]
ASF GitHub Bot logged work on BEAM-3327:
----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Apr/18 00:36
Start Date: 21/Apr/18 00:36
Worklog Time Spent: 10m
Work Description: bsidhom commented on a change in pull request #5189:
[BEAM-3327] Basic Docker environment factory
URL: https://github.com/apache/beam/pull/5189#discussion_r183190992
##########
File path:
runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/control/FnApiControlClientPoolService.java
##########
@@ -78,8 +83,16 @@ public static FnApiControlClientPoolService
offeringClientsToPool(
// service is closed, in which case the client will be discarded when
the service is
// discarded, which should be performed by a call to #shutdownNow. The
remote caller must be
// able to handle an unexpectedly terminated connection.
- vendedClients.add(newClient);
- clientPool.accept(newClient);
+ synchronized (lock) {
+ checkState(
+ !closed, "%s already closed",
FnApiControlClientPoolService.class.getSimpleName());
+ // TODO: https://issues.apache.org/jira/browse/BEAM-4151: Prevent
stale client references
+ // from leaking.
+ vendedClients.add(newClient);
+ }
+ // NOTE: The client sink must provide its own thread safety. We do not
attempt to
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 93506)
Time Spent: 16h 50m (was: 16h 40m)
> Add abstractions to manage Environment Instance lifecycles.
> -----------------------------------------------------------
>
> Key: BEAM-3327
> URL: https://issues.apache.org/jira/browse/BEAM-3327
> Project: Beam
> Issue Type: New Feature
> Components: runner-core
> Reporter: Thomas Groh
> Assignee: Ben Sidhom
> Priority: Major
> Labels: portability
> Time Spent: 16h 50m
> Remaining Estimate: 0h
>
> This permits remote stage execution for arbitrary environments
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
