[
https://issues.apache.org/jira/browse/BEAM-2163?focusedWorklogId=93510&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-93510
]
ASF GitHub Bot logged work on BEAM-2163:
----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Apr/18 00:53
Start Date: 21/Apr/18 00:53
Worklog Time Spent: 10m
Work Description: JavierAntonioGonzalezTrejo opened a new pull request
#5199: [BEAM-2163] Remove the dependency on examples from ptransform_test
URL: https://github.com/apache/beam/pull/5199
The test_read_metrics function no longer depends on
the snippets file. The CountingSource class is contained
in the function itself.
DESCRIPTION HERE
------------------------
Follow this checklist to help us incorporate your contribution quickly and
easily:
- [x] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the
change (usually before you start working on it). Trivial changes like typos do
not require a JIRA issue. Your pull request should address just this issue,
without pulling in other changes.
- [x] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue.
- [x] Write a pull request description that is detailed enough to
understand:
- [ ] What the pull request does
- [ ] Why it does it
- [ ] How it does it
- [ ] Why this approach
- [] Each commit in the pull request should have a meaningful subject line
and body.
- [x] Run `./gradlew build` to make sure basic checks pass. A more thorough
check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 93510)
Time Spent: 10m
Remaining Estimate: 0h
> Remove the dependency on examples from ptransform_test
> ------------------------------------------------------
>
> Key: BEAM-2163
> URL: https://issues.apache.org/jira/browse/BEAM-2163
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: Sourabh Bajaj
> Priority: Major
> Labels: newbie, starter
> Time Spent: 10m
> Remaining Estimate: 0h
>
> https://github.com/apache/beam/blob/master/sdks/python/apache_beam/transforms/ptransform_test.py#L176
> This validates runner test depends on the Counting source snippet and the
> source should be copied here instead of this dependency.
> The actual beam code should not depend on the examples package at all.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
