[
https://issues.apache.org/jira/browse/BEAM-4138?focusedWorklogId=94126&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-94126
]
ASF GitHub Bot logged work on BEAM-4138:
----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Apr/18 15:32
Start Date: 23/Apr/18 15:32
Worklog Time Spent: 10m
Work Description: echauchot opened a new pull request #5203: [BEAM-4138]
Support runners that do not support committed metrics in MetricsHttpSink
URL: https://github.com/apache/beam/pull/5203
This PR is based on https://github.com/apache/beam/pull/4548
------------------------
Follow this checklist to help us incorporate your contribution quickly and
easily:
- [X] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the
change (usually before you start working on it). Trivial changes like typos do
not require a JIRA issue. Your pull request should address just this issue,
without pulling in other changes.
- [X] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue.
- [ ] Write a pull request description that is detailed enough to
understand:
- [ ] What the pull request does
- [ ] Why it does it
- [ ] How it does it
- [ ] Why this approach
- [X] Each commit in the pull request should have a meaningful subject line
and body.
- [X] Run `./gradlew build` to make sure basic checks pass. A more thorough
check will be performed on your pull request automatically.
- [X] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 94126)
Time Spent: 10m
Remaining Estimate: 0h
> support runners that do not support committed metrics in MetricsHttpSink
> ------------------------------------------------------------------------
>
> Key: BEAM-4138
> URL: https://issues.apache.org/jira/browse/BEAM-4138
> Project: Beam
> Issue Type: Improvement
> Components: runner-ideas
> Reporter: Etienne Chauchot
> Assignee: Etienne Chauchot
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> {{MetricsHttpSink}} is currently more a POC implementation of the new
> {{MetricsSink}} interface. But if users want to use it on runners that do not
> support committed metrics, then it needs to avoid calling related
> {{getCommitted()}} methods to avoid the {{UnsupportedException}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
