[
https://issues.apache.org/jira/browse/BEAM-4165?focusedWorklogId=94734&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-94734
]
ASF GitHub Bot logged work on BEAM-4165:
----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Apr/18 18:13
Start Date: 24/Apr/18 18:13
Worklog Time Spent: 10m
Work Description: yifanzou closed pull request #5213: BEAM-4165, remove
node restrictions of Python Jenkins tests
URL: https://github.com/apache/beam/pull/5213
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/.test-infra/jenkins/job_beam_PostCommit_Python_ValidatesContainer_Dataflow.groovy
b/.test-infra/jenkins/job_beam_PostCommit_Python_ValidatesContainer_Dataflow.groovy
index 5a76b03fa17..90344107b13 100644
---
a/.test-infra/jenkins/job_beam_PostCommit_Python_ValidatesContainer_Dataflow.groovy
+++
b/.test-infra/jenkins/job_beam_PostCommit_Python_ValidatesContainer_Dataflow.groovy
@@ -35,18 +35,6 @@ job('beam_PostCommit_Python_ValidatesContainer_Dataflow') {
'Google Cloud Dataflow Runner Python ValidatesContainer Tests',
'Run Python Dataflow ValidatesContainer')
- // Allow the test to only run on particular nodes
- // TODO(BEAM-1817): Remove once the tests can run on all nodes
- parameters {
- nodeParam('TEST_HOST') {
- description('select test host as either beam1, 2 or 3')
- defaultNodes(['beam1', 'beam2', 'beam3'])
- allowedNodes(['beam1', 'beam2', 'beam3'])
- trigger('multiSelectionDisallowed')
- eligibility('IgnoreOfflineNodeEligibility')
- }
- }
-
// Execute shell command to test Python SDK.
steps {
shell('cd ' + common_job_properties.checkoutDir + ' && bash
sdks/python/container/run_validatescontainer.sh')
diff --git
a/.test-infra/jenkins/job_beam_PostCommit_Python_ValidatesRunner_Dataflow.groovy
b/.test-infra/jenkins/job_beam_PostCommit_Python_ValidatesRunner_Dataflow.groovy
index 8a8714af26d..392a93598c7 100644
---
a/.test-infra/jenkins/job_beam_PostCommit_Python_ValidatesRunner_Dataflow.groovy
+++
b/.test-infra/jenkins/job_beam_PostCommit_Python_ValidatesRunner_Dataflow.groovy
@@ -35,18 +35,6 @@ job('beam_PostCommit_Python_ValidatesRunner_Dataflow') {
'Google Cloud Dataflow Runner Python ValidatesRunner Tests',
'Run Python Dataflow ValidatesRunner')
- // Allow the test to only run on particular nodes
- // TODO(BEAM-1817): Remove once the tests can run on all nodes
- parameters {
- nodeParam('TEST_HOST') {
- description('select test host as either beam1, 2 or 3')
- defaultNodes(['beam1', 'beam2', 'beam3'])
- allowedNodes(['beam1', 'beam2', 'beam3'])
- trigger('multiSelectionDisallowed')
- eligibility('IgnoreOfflineNodeEligibility')
- }
- }
-
// Execute shell command to test Python SDK.
steps {
shell('cd ' + common_job_properties.checkoutDir + ' && bash
sdks/python/run_validatesrunner.sh')
diff --git a/.test-infra/jenkins/job_beam_PostCommit_Python_Verify.groovy
b/.test-infra/jenkins/job_beam_PostCommit_Python_Verify.groovy
index 6498e39fd9d..73a918e13a6 100644
--- a/.test-infra/jenkins/job_beam_PostCommit_Python_Verify.groovy
+++ b/.test-infra/jenkins/job_beam_PostCommit_Python_Verify.groovy
@@ -36,18 +36,6 @@ job('beam_PostCommit_Python_Verify') {
'Python SDK PostCommit Tests',
'Run Python PostCommit')
- // Allow the test to only run on particular nodes
- // TODO(BEAM-1817): Remove once the tests can run on all nodes
- parameters {
- nodeParam('TEST_HOST') {
- description('select test host as either beam1, 2 or 3')
- defaultNodes(['beam1', 'beam2', 'beam3'])
- allowedNodes(['beam1', 'beam2', 'beam3'])
- trigger('multiSelectionDisallowed')
- eligibility('IgnoreOfflineNodeEligibility')
- }
- }
-
// Execute shell command to test Python SDK.
steps {
shell('cd ' + common_job_properties.checkoutDir + ' && bash
sdks/python/run_postcommit.sh')
diff --git a/.test-infra/jenkins/job_beam_PreCommit_Python_GradleBuild.groovy
b/.test-infra/jenkins/job_beam_PreCommit_Python_GradleBuild.groovy
index 5904fcbee29..cc58dc005ed 100644
--- a/.test-infra/jenkins/job_beam_PreCommit_Python_GradleBuild.groovy
+++ b/.test-infra/jenkins/job_beam_PreCommit_Python_GradleBuild.groovy
@@ -38,18 +38,6 @@ job('beam_PreCommit_Python_GradleBuild') {
archiveJunit('**/nosetests.xml')
}
- // Allow the test to only run on particular nodes
- // TODO(BEAM-1817): Remove once the tests can run on all nodes
- parameters {
- nodeParam('TEST_HOST') {
- description('select test host as either beam1, 2 or 6')
- defaultNodes(['beam2'])
- allowedNodes(['beam1', 'beam2', 'beam6'])
- trigger('multiSelectionDisallowed')
- eligibility('IgnoreOfflineNodeEligibility')
- }
- }
-
def gradle_command_line = './gradlew ' +
common_job_properties.gradle_switches.join(' ') + ' :pythonPreCommit'
// Sets that this is a PreCommit job.
common_job_properties.setPreCommit(delegate, gradle_command_line, 'Run
Python PreCommit')
diff --git a/.test-infra/jenkins/job_beam_ReleaseCandidate_Python.groovy
b/.test-infra/jenkins/job_beam_ReleaseCandidate_Python.groovy
index d1d9f6d7a68..22ed5790645 100644
--- a/.test-infra/jenkins/job_beam_ReleaseCandidate_Python.groovy
+++ b/.test-infra/jenkins/job_beam_ReleaseCandidate_Python.groovy
@@ -27,16 +27,6 @@ job('beam_PostRelease_Python_Candidate') {
// Set common parameters.
common_job_properties.setTopLevelMainJobProperties(delegate)
- parameters {
- nodeParam('TEST_HOST') {
- description('select test host as either beam1, 2 or 3')
- defaultNodes(['beam1', 'beam2', 'beam3'])
- allowedNodes(['beam1', 'beam2', 'beam3'])
- trigger('multiSelectionDisallowed')
- eligibility('IgnoreOfflineNodeEligibility')
- }
- }
-
// Allows triggering this build against pull requests.
common_job_properties.enablePhraseTriggeringFromPullRequest(
delegate,
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 94734)
Time Spent: 50m (was: 40m)
> Fix python jenkins tests
> ------------------------
>
> Key: BEAM-4165
> URL: https://issues.apache.org/jira/browse/BEAM-4165
> Project: Beam
> Issue Type: Bug
> Components: testing
> Reporter: yifan zou
> Assignee: yifan zou
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
