[
https://issues.apache.org/jira/browse/BEAM-4166?focusedWorklogId=94825&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-94825
]
ASF GitHub Bot logged work on BEAM-4166:
----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Apr/18 22:24
Start Date: 24/Apr/18 22:24
Worklog Time Spent: 10m
Work Description: jkff commented on issue #5216: [BEAM-4166] Invoke
@Setup in FnApiDoFnRunner
URL: https://github.com/apache/beam/pull/5216#issuecomment-384099286
Thanks! As for tracking Teardown - I think the current JIRA
https://issues.apache.org/jira/browse/BEAM-4166 is an appropriate place to
track it. The current PR addresses the Setup side of things; the Teardown side
can be addressed either by another PR adding Teardown, or by closing the JIRA
as "won't fix" with an explanation as to why calling Teardown here is
unnecessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 94825)
Time Spent: 40m (was: 0.5h)
> FnApiDoFnRunner doesn't invoke setup/teardown
> ---------------------------------------------
>
> Key: BEAM-4166
> URL: https://issues.apache.org/jira/browse/BEAM-4166
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-harness
> Reporter: Eugene Kirpichov
> Assignee: Eugene Kirpichov
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> And we apparently lack test coverage for that - one would think that
> ValidatesRunner tests would check lifecycle.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
