[
https://issues.apache.org/jira/browse/BEAM-3979?focusedWorklogId=94835&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-94835
]
ASF GitHub Bot logged work on BEAM-3979:
----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Apr/18 22:51
Start Date: 24/Apr/18 22:51
Worklog Time Spent: 10m
Work Description: kennknowles commented on a change in pull request
#4989: [BEAM-3979] Start completing the new DoFn vision: plumb context
parameters into process functions.
URL: https://github.com/apache/beam/pull/4989#discussion_r183902864
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/DoFnTester.java
##########
@@ -654,6 +687,41 @@ public Void
dispatch(DoFnSignature.Parameter.WindowParameter p) {
return null;
}
+ @Override
+ @Nullable
+ public Void dispatch(DoFnSignature.Parameter.ElementParameter p) {
+ return null;
Review comment:
I don't think any of these should be null or nullable, but should throw.
They are also totally not necessary, since `WithDefault` means you don't
have to override any case you are not interested in.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 94835)
> New DoFn should allow injecting of all parameters in ProcessContext
> -------------------------------------------------------------------
>
> Key: BEAM-3979
> URL: https://issues.apache.org/jira/browse/BEAM-3979
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Affects Versions: 2.4.0
> Reporter: Reuven Lax
> Assignee: Reuven Lax
> Priority: Major
> Fix For: 2.5.0
>
> Time Spent: 3h
> Remaining Estimate: 0h
>
> This was intended in the past, but never completed. Ideally all primitive
> parameters in ProcessContext should be injectable, and OutputReceiver
> parameters can be used to collection output. So, we should be able to write a
> DoFn as follows
> @ProcessElement
> public void process(@Element String word, OutputReceiver<String> receiver) {
> receiver.output(word.toUpperCase());
> }
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
