[
https://issues.apache.org/jira/browse/BEAM-3925?focusedWorklogId=95631&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-95631
]
ASF GitHub Bot logged work on BEAM-3925:
----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Apr/18 17:02
Start Date: 26/Apr/18 17:02
Worklog Time Spent: 10m
Work Description: rangadi commented on a change in pull request #5141:
[BEAM-3925] Allow ValueProvider for KafkaIO so that we can create Beam
Templates using KafkaIO
URL: https://github.com/apache/beam/pull/5141#discussion_r184170193
##########
File path:
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaExactlyOnceSink.java
##########
@@ -168,7 +168,7 @@ static void ensureEOSSupport() {
.apply("Assign sequential ids", ParDo.of(new Sequencer<>()))
.apply("Persist ids", GroupByKey.create())
.apply(
- String.format("Write to Kafka topic '%s'", spec.getTopic()),
+ String.format("Write to Kafka topic '%s'", spec.getTopic().get()),
Review comment:
Code executes on the graph build time. get() does not work for runtime
values there (which would be the case for templates, right?). You can check if
the value is available and not include it in the transform name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 95631)
Time Spent: 3h 20m (was: 3h 10m)
> Allow ValueProvider for KafkaIO
> -------------------------------
>
> Key: BEAM-3925
> URL: https://issues.apache.org/jira/browse/BEAM-3925
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Sameer Abhyankar
> Assignee: Pramod Upamanyu
> Priority: Major
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> Add ValueProvider support for the various methods in KafkaIO. This would
> allow us to use KafkaIO in reusable pipeline templates.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
