This is an automated email from the ASF dual-hosted git repository.
lcwik pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/beam.git
The following commit(s) were added to refs/heads/master by this push:
new 77cbcd2 Removing some unused local variables (#4684)
77cbcd2 is described below
commit 77cbcd20655816c6b923fe54f31d29a8fe76aef0
Author: Colm O hEigeartaigh <cohei...@users.noreply.github.com>
AuthorDate: Thu Apr 26 18:36:37 2018 +0100
Removing some unused local variables (#4684)
* Removing some unused local variables
* Minor clean-up
* Checkstyle fix
---
.../core/construction/WindowIntoTranslation.java | 1 -
.../construction/PCollectionTranslationTest.java | 35 ++-
.../core/construction/PTransformMatchersTest.java | 2 +-
.../core/construction/ParDoTranslationTest.java | 3 -
.../SingleInputOutputOverrideFactoryTest.java | 5 +-
.../core/construction/UnconsumedReadsTest.java | 4 +-
.../apache/beam/runners/core/ReduceFnTester.java | 12 +-
.../beam/runners/flink/PipelineOptionsTest.java | 25 +-
.../runners/dataflow/BatchViewOverridesTest.java | 4 -
.../beam/runners/dataflow/DataflowRunnerTest.java | 4 +-
.../org/apache/beam/sdk/coders/AvroCoderTest.java | 3 -
.../sdk/options/PipelineOptionsFactoryTest.java | 3 +-
.../apache/beam/sdk/options/ValueProviderTest.java | 4 +-
.../beam/sdk/transforms/FlatMapElementsTest.java | 31 ++-
.../beam/sdk/transforms/MapElementsTest.java | 62 +++--
.../org/apache/beam/sdk/transforms/ParDoTest.java | 4 +-
.../beam/sdk/transforms/SimpleFunctionTest.java | 2 +-
.../sdk/transforms/reflect/DoFnSignaturesTest.java | 259 ++++++++++-----------
.../beam/sdk/transforms/windowing/WindowTest.java | 14 +-
.../extensions/jackson/JacksonTransformsTest.java | 7 +-
.../sdk/extensions/sql/BeamSqlDslFilterTest.java | 9 +-
.../impl/interpreter/BeamSqlFnExecutorTest.java | 12 +-
.../harness/logging/BeamFnLoggingClientTest.java | 2 -
.../sdk/io/gcp/bigquery/FakeDatasetService.java | 3 +-
.../beam/sdk/io/gcp/datastore/DatastoreV1Test.java | 2 +-
.../beam/sdk/io/gcp/pubsub/PubsubIOTest.java | 5 -
26 files changed, 232 insertions(+), 285 deletions(-)
diff --git
a/runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/WindowIntoTranslation.java
b/runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/WindowIntoTranslation.java
index c714cbc..89091b8 100644
---
a/runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/WindowIntoTranslation.java
+++
b/runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/WindowIntoTranslation.java
@@ -86,7 +86,6 @@ public class WindowIntoTranslation {
application.getFullName(),
transformProto.getSpec().getUrn());
- WindowIntoPayload windowIntoPayload;
try {
return
WindowIntoPayload.parseFrom(transformProto.getSpec().getPayload());
} catch (InvalidProtocolBufferException exc) {
diff --git
a/runners/core-construction-java/src/test/java/org/apache/beam/runners/core/construction/PCollectionTranslationTest.java
b/runners/core-construction-java/src/test/java/org/apache/beam/runners/core/construction/PCollectionTranslationTest.java
index 4445e0b..83fb7dc 100644
---
a/runners/core-construction-java/src/test/java/org/apache/beam/runners/core/construction/PCollectionTranslationTest.java
+++
b/runners/core-construction-java/src/test/java/org/apache/beam/runners/core/construction/PCollectionTranslationTest.java
@@ -86,24 +86,23 @@ public class PCollectionTranslationTest {
pipeline
.apply("counts with alternative coder",
GenerateSequence.from(0).to(10))
.setCoder(BigEndianLongCoder.of());
- PCollection<Integer> allCustomInts =
- pipeline
- .apply(
- "intsWithCustomCoder",
- Create.of(1, 2)
- .withCoder(new
AutoValue_PCollectionTranslationTest_CustomIntCoder()))
- .apply(
- "into custom windows",
- Window.into(new CustomWindows())
- .triggering(
- AfterWatermark.pastEndOfWindow()
- .withEarlyFirings(
- AfterFirst.of(
- AfterPane.elementCountAtLeast(5),
-
AfterProcessingTime.pastFirstElementInPane()
- .plusDelayOf(Duration.millis(227L)))))
- .accumulatingFiredPanes()
- .withAllowedLateness(Duration.standardMinutes(12L)));
+ pipeline
+ .apply(
+ "intsWithCustomCoder",
+ Create.of(1, 2)
+ .withCoder(new
AutoValue_PCollectionTranslationTest_CustomIntCoder()))
+ .apply(
+ "into custom windows",
+ Window.into(new CustomWindows())
+ .triggering(
+ AfterWatermark.pastEndOfWindow()
+ .withEarlyFirings(
+ AfterFirst.of(
+ AfterPane.elementCountAtLeast(5),
+ AfterProcessingTime.pastFirstElementInPane()
+ .plusDelayOf(Duration.millis(227L)))))
+ .accumulatingFiredPanes()
+ .withAllowedLateness(Duration.standardMinutes(12L)));
return ImmutableList.of(ints, longs, windowedLongs, coderLongs,
groupedStrings);
}
diff --git
a/runners/core-construction-java/src/test/java/org/apache/beam/runners/core/construction/PTransformMatchersTest.java
b/runners/core-construction-java/src/test/java/org/apache/beam/runners/core/construction/PTransformMatchersTest.java
index 61a29f7..53c3731 100644
---
a/runners/core-construction-java/src/test/java/org/apache/beam/runners/core/construction/PTransformMatchersTest.java
+++
b/runners/core-construction-java/src/test/java/org/apache/beam/runners/core/construction/PTransformMatchersTest.java
@@ -526,7 +526,7 @@ public class PTransformMatchersTest implements Serializable
{
WriteFiles.to(
new FileBasedSink<Integer, Void, Integer>(
StaticValueProvider.of(outputDirectory),
- DynamicFileDestinations.constant(new FakeFilenamePolicy())) {
+ DynamicFileDestinations.constant(policy)) {
@Override
public WriteOperation<Void, Integer> createWriteOperation() {
return null;
diff --git
a/runners/core-construction-java/src/test/java/org/apache/beam/runners/core/construction/ParDoTranslationTest.java
b/runners/core-construction-java/src/test/java/org/apache/beam/runners/core/construction/ParDoTranslationTest.java
index 9bd7fe4..e45e4db 100644
---
a/runners/core-construction-java/src/test/java/org/apache/beam/runners/core/construction/ParDoTranslationTest.java
+++
b/runners/core-construction-java/src/test/java/org/apache/beam/runners/core/construction/ParDoTranslationTest.java
@@ -28,7 +28,6 @@ import java.util.Map;
import org.apache.beam.model.pipeline.v1.RunnerApi;
import org.apache.beam.model.pipeline.v1.RunnerApi.ParDoPayload;
import org.apache.beam.model.pipeline.v1.RunnerApi.SideInput;
-import org.apache.beam.sdk.Pipeline;
import org.apache.beam.sdk.coders.KvCoder;
import org.apache.beam.sdk.coders.StringUtf8Coder;
import org.apache.beam.sdk.coders.VarIntCoder;
@@ -149,8 +148,6 @@ public class ParDoTranslationTest {
RehydratedComponents.forComponents(components);
// Decode
- Pipeline rehydratedPipeline = Pipeline.create();
-
ParDoPayload parDoPayload =
ParDoPayload.parseFrom(protoTransform.getSpec().getPayload());
for (PCollectionView<?> view : parDo.getSideInputs()) {
SideInput sideInput =
parDoPayload.getSideInputsOrThrow(view.getTagInternal().getId());
diff --git
a/runners/core-construction-java/src/test/java/org/apache/beam/runners/core/construction/SingleInputOutputOverrideFactoryTest.java
b/runners/core-construction-java/src/test/java/org/apache/beam/runners/core/construction/SingleInputOutputOverrideFactoryTest.java
index fdae1ff..24ebe5d 100644
---
a/runners/core-construction-java/src/test/java/org/apache/beam/runners/core/construction/SingleInputOutputOverrideFactoryTest.java
+++
b/runners/core-construction-java/src/test/java/org/apache/beam/runners/core/construction/SingleInputOutputOverrideFactoryTest.java
@@ -96,8 +96,7 @@ public class SingleInputOutputOverrideFactoryTest implements
Serializable {
PCollection<Integer> output = input.apply("Map", MapElements.via(fn));
PCollection<Integer> reappliedOutput = input.apply("ReMap",
MapElements.via(fn));
thrown.expect(IllegalArgumentException.class);
- Map<PValue, ReplacementOutput> replacementMap =
- factory.mapOutputs(
-
PCollectionList.of(output).and(input).and(reappliedOutput).expand(),
reappliedOutput);
+ factory.mapOutputs(
+ PCollectionList.of(output).and(input).and(reappliedOutput).expand(),
reappliedOutput);
}
}
diff --git
a/runners/core-construction-java/src/test/java/org/apache/beam/runners/core/construction/UnconsumedReadsTest.java
b/runners/core-construction-java/src/test/java/org/apache/beam/runners/core/construction/UnconsumedReadsTest.java
index 34cbd37..09df3a0 100644
---
a/runners/core-construction-java/src/test/java/org/apache/beam/runners/core/construction/UnconsumedReadsTest.java
+++
b/runners/core-construction-java/src/test/java/org/apache/beam/runners/core/construction/UnconsumedReadsTest.java
@@ -49,7 +49,7 @@ public class UnconsumedReadsTest {
@Test
public void matcherProducesUnconsumedValueBoundedRead() {
Bounded<Long> transform = Read.from(CountingSource.upTo(20L));
- PCollection<Long> output = pipeline.apply(transform);
+ pipeline.apply(transform);
UnconsumedReads.ensureAllReadsConsumed(pipeline);
validateConsumed();
}
@@ -57,7 +57,7 @@ public class UnconsumedReadsTest {
@Test
public void matcherProducesUnconsumedValueUnboundedRead() {
Unbounded<Long> transform = Read.from(CountingSource.unbounded());
- PCollection<Long> output = pipeline.apply(transform);
+ pipeline.apply(transform);
UnconsumedReads.ensureAllReadsConsumed(pipeline);
validateConsumed();
}
diff --git
a/runners/core-java/src/test/java/org/apache/beam/runners/core/ReduceFnTester.java
b/runners/core-java/src/test/java/org/apache/beam/runners/core/ReduceFnTester.java
index 4dd0b42..7ad19c9 100644
---
a/runners/core-java/src/test/java/org/apache/beam/runners/core/ReduceFnTester.java
+++
b/runners/core-java/src/test/java/org/apache/beam/runners/core/ReduceFnTester.java
@@ -173,9 +173,9 @@ public class ReduceFnTester<InputT, OutputT, W extends
BoundedWindow> {
throws Exception {
CoderRegistry registry = CoderRegistry.createDefault();
- AppliedCombineFn<String, Integer, AccumT, OutputT> fn =
- AppliedCombineFn.withInputCoder(
- combineFn, registry, KvCoder.of(StringUtf8Coder.of(),
VarIntCoder.of()));
+ // Ensure that the CombineFn can be converted into an AppliedCombineFn
+ AppliedCombineFn.withInputCoder(
+ combineFn, registry, KvCoder.of(StringUtf8Coder.of(),
VarIntCoder.of()));
return combining(
strategy,
@@ -222,9 +222,9 @@ public class ReduceFnTester<InputT, OutputT, W extends
BoundedWindow> {
SideInputReader sideInputReader)
throws Exception {
CoderRegistry registry = CoderRegistry.createDefault();
- AppliedCombineFn<String, Integer, AccumT, OutputT> fn =
- AppliedCombineFn.withInputCoder(
- combineFn, registry, KvCoder.of(StringUtf8Coder.of(),
VarIntCoder.of()));
+ // Ensure that the CombineFn can be converted into an AppliedCombineFn
+ AppliedCombineFn.withInputCoder(
+ combineFn, registry, KvCoder.of(StringUtf8Coder.of(),
VarIntCoder.of()));
return combining(
strategy,
diff --git
a/runners/flink/src/test/java/org/apache/beam/runners/flink/PipelineOptionsTest.java
b/runners/flink/src/test/java/org/apache/beam/runners/flink/PipelineOptionsTest.java
index 5c99cf5..e91b4d6 100644
---
a/runners/flink/src/test/java/org/apache/beam/runners/flink/PipelineOptionsTest.java
+++
b/runners/flink/src/test/java/org/apache/beam/runners/flink/PipelineOptionsTest.java
@@ -62,19 +62,18 @@ public class PipelineOptionsTest {
public void parDoBaseClassPipelineOptionsNullTest() {
TupleTag<String> mainTag = new TupleTag<>("main-output");
Coder<WindowedValue<String>> coder =
WindowedValue.getValueOnlyCoder(StringUtf8Coder.of());
- DoFnOperator<String, String> doFnOperator =
- new DoFnOperator<>(
- new TestDoFn(),
- "stepName",
- coder,
- mainTag,
- Collections.emptyList(),
- new DoFnOperator.MultiOutputOutputManagerFactory<>(mainTag, coder),
- WindowingStrategy.globalDefault(),
- new HashMap<>(),
- Collections.emptyList(),
- null,
- null);
+ new DoFnOperator<>(
+ new TestDoFn(),
+ "stepName",
+ coder,
+ mainTag,
+ Collections.emptyList(),
+ new DoFnOperator.MultiOutputOutputManagerFactory<>(mainTag, coder),
+ WindowingStrategy.globalDefault(),
+ new HashMap<>(),
+ Collections.emptyList(),
+ null,
+ null);
}
/**
diff --git
a/runners/google-cloud-dataflow-java/src/test/java/org/apache/beam/runners/dataflow/BatchViewOverridesTest.java
b/runners/google-cloud-dataflow-java/src/test/java/org/apache/beam/runners/dataflow/BatchViewOverridesTest.java
index 0a70ce9..a6847c7 100644
---
a/runners/google-cloud-dataflow-java/src/test/java/org/apache/beam/runners/dataflow/BatchViewOverridesTest.java
+++
b/runners/google-cloud-dataflow-java/src/test/java/org/apache/beam/runners/dataflow/BatchViewOverridesTest.java
@@ -368,8 +368,6 @@ public class BatchViewOverridesTest {
@Test
public void testToIsmMetadataRecordForSizeDoFn() throws Exception {
- TupleTag<KV<Integer, KV<IntervalWindow, Long>>> outputForSizeTag = new
TupleTag<>();
- TupleTag<KV<Integer, KV<IntervalWindow, Long>>> outputForEntrySetTag = new
TupleTag<>();
Coder<Long> keyCoder = VarLongCoder.of();
Coder<IntervalWindow> windowCoder = IntervalWindow.getCoder();
@@ -419,8 +417,6 @@ public class BatchViewOverridesTest {
@Test
public void testToIsmMetadataRecordForKeyDoFn() throws Exception {
- TupleTag<KV<Integer, KV<IntervalWindow, Long>>> outputForSizeTag = new
TupleTag<>();
- TupleTag<KV<Integer, KV<IntervalWindow, Long>>> outputForEntrySetTag = new
TupleTag<>();
Coder<Long> keyCoder = VarLongCoder.of();
Coder<IntervalWindow> windowCoder = IntervalWindow.getCoder();
diff --git
a/runners/google-cloud-dataflow-java/src/test/java/org/apache/beam/runners/dataflow/DataflowRunnerTest.java
b/runners/google-cloud-dataflow-java/src/test/java/org/apache/beam/runners/dataflow/DataflowRunnerTest.java
index a8b128d..75d4353 100644
---
a/runners/google-cloud-dataflow-java/src/test/java/org/apache/beam/runners/dataflow/DataflowRunnerTest.java
+++
b/runners/google-cloud-dataflow-java/src/test/java/org/apache/beam/runners/dataflow/DataflowRunnerTest.java
@@ -535,7 +535,7 @@ public class DataflowRunnerTest implements Serializable {
DataflowPipelineOptions dataflowOptions = buildPipelineOptions();
RuntimeTestOptions options = dataflowOptions.as(RuntimeTestOptions.class);
Pipeline p = buildDataflowPipeline(dataflowOptions);
- PCollection<String> unconsumed =
p.apply(TextIO.read().from(options.getInput()));
+ p.apply(TextIO.read().from(options.getInput()));
DataflowRunner.fromOptions(dataflowOptions).replaceTransforms(p);
final AtomicBoolean unconsumedSeenAsInput = new AtomicBoolean();
p.traverseTopologically(new PipelineVisitor.Defaults() {
@@ -1181,7 +1181,7 @@ public class DataflowRunnerTest implements Serializable {
public void testSetStateUnsupportedInBatch() throws Exception {
PipelineOptions options = buildPipelineOptions();
options.as(StreamingOptions.class).setStreaming(false);
- Pipeline p = Pipeline.create(options);
+ Pipeline.create(options);
verifySetStateUnsupported(options);
}
diff --git
a/sdks/java/core/src/test/java/org/apache/beam/sdk/coders/AvroCoderTest.java
b/sdks/java/core/src/test/java/org/apache/beam/sdk/coders/AvroCoderTest.java
index 9c8c5bf..4e94315 100644
--- a/sdks/java/core/src/test/java/org/apache/beam/sdk/coders/AvroCoderTest.java
+++ b/sdks/java/core/src/test/java/org/apache/beam/sdk/coders/AvroCoderTest.java
@@ -198,9 +198,6 @@ public class AvroCoderTest {
Object cloned1 = CoderUtils.clone(avroCoder1, pojo1);
Object cloned2 = CoderUtils.clone(avroCoder2, pojo2);
- Class<?> class1 = cloned1.getClass();
- Class<?> class2 = cloned2.getClass();
-
// Confirming that the uncorrupted coder is fine
pojoClass1.cast(cloned1);
diff --git
a/sdks/java/core/src/test/java/org/apache/beam/sdk/options/PipelineOptionsFactoryTest.java
b/sdks/java/core/src/test/java/org/apache/beam/sdk/options/PipelineOptionsFactoryTest.java
index be92f2a..4667bf7 100644
---
a/sdks/java/core/src/test/java/org/apache/beam/sdk/options/PipelineOptionsFactoryTest.java
+++
b/sdks/java/core/src/test/java/org/apache/beam/sdk/options/PipelineOptionsFactoryTest.java
@@ -1684,8 +1684,7 @@ public class PipelineOptionsFactoryTest {
+ " - org.apache.beam.sdk.options.PipelineOptionsFactoryTest"
+ "$InvalidPipelineOptions2");
- PipelineOptionsInheritedInvalid options = PipelineOptionsFactory.as(
- PipelineOptionsInheritedInvalid.class);
+ PipelineOptionsFactory.as(PipelineOptionsInheritedInvalid.class);
}
private String emptyStringErrorMessage() {
diff --git
a/sdks/java/core/src/test/java/org/apache/beam/sdk/options/ValueProviderTest.java
b/sdks/java/core/src/test/java/org/apache/beam/sdk/options/ValueProviderTest.java
index 46ea620..9ca88c2 100644
---
a/sdks/java/core/src/test/java/org/apache/beam/sdk/options/ValueProviderTest.java
+++
b/sdks/java/core/src/test/java/org/apache/beam/sdk/options/ValueProviderTest.java
@@ -175,7 +175,7 @@ public class ValueProviderTest {
expectedException.expectMessage(
"Method getBar should not have return type "
+ "RuntimeValueProvider, use ValueProvider instead.");
- RuntimeValueProvider<String> provider = options.getBar();
+ options.getBar();
}
/** A test interface. */
@@ -191,7 +191,7 @@ public class ValueProviderTest {
expectedException.expectMessage(
"Method getBar should not have return type "
+ "StaticValueProvider, use ValueProvider instead.");
- StaticValueProvider<String> provider = options.getBar();
+ options.getBar();
}
diff --git
a/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/FlatMapElementsTest.java
b/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/FlatMapElementsTest.java
index 7c15c09..29175af 100644
---
a/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/FlatMapElementsTest.java
+++
b/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/FlatMapElementsTest.java
@@ -149,23 +149,22 @@ public class FlatMapElementsTest implements Serializable {
public void testPolymorphicSimpleFunction() throws Exception {
pipeline.enableAbandonedNodeEnforcement(false);
- PCollection<Integer> output =
- pipeline
- .apply(Create.of(1, 2, 3))
-
- // This is the function that needs to propagate the input T to
output T
- .apply("Polymorphic Identity", MapElements.via(new
PolymorphicSimpleFunction<>()))
+ pipeline
+ .apply(Create.of(1, 2, 3))
- // This is a consumer to ensure that all coder inference logic is
executed.
- .apply(
- "Test Consumer",
- MapElements.via(
- new SimpleFunction<Iterable<Integer>, Integer>() {
- @Override
- public Integer apply(Iterable<Integer> input) {
- return 42;
- }
- }));
+ // This is the function that needs to propagate the input T to output T
+ .apply("Polymorphic Identity", MapElements.via(new
PolymorphicSimpleFunction<>()))
+
+ // This is a consumer to ensure that all coder inference logic is
executed.
+ .apply(
+ "Test Consumer",
+ MapElements.via(
+ new SimpleFunction<Iterable<Integer>, Integer>() {
+ @Override
+ public Integer apply(Iterable<Integer> input) {
+ return 42;
+ }
+ }));
}
@Test
diff --git
a/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/MapElementsTest.java
b/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/MapElementsTest.java
index 96a4cc8..640641d 100644
---
a/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/MapElementsTest.java
+++
b/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/MapElementsTest.java
@@ -127,23 +127,22 @@ public class MapElementsTest implements Serializable {
public void testPolymorphicSimpleFunction() throws Exception {
pipeline.enableAbandonedNodeEnforcement(false);
- PCollection<Integer> output =
- pipeline
- .apply(Create.of(1, 2, 3))
-
- // This is the function that needs to propagate the input T to
output T
- .apply("Polymorphic Identity", MapElements.via(new
PolymorphicSimpleFunction<>()))
+ pipeline
+ .apply(Create.of(1, 2, 3))
- // This is a consumer to ensure that all coder inference logic is
executed.
- .apply(
- "Test Consumer",
- MapElements.via(
- new SimpleFunction<Integer, Integer>() {
- @Override
- public Integer apply(Integer input) {
- return input;
- }
- }));
+ // This is the function that needs to propagate the input T to output T
+ .apply("Polymorphic Identity", MapElements.via(new
PolymorphicSimpleFunction<>()))
+
+ // This is a consumer to ensure that all coder inference logic is
executed.
+ .apply(
+ "Test Consumer",
+ MapElements.via(
+ new SimpleFunction<Integer, Integer>() {
+ @Override
+ public Integer apply(Integer input) {
+ return input;
+ }
+ }));
}
/**
@@ -154,23 +153,22 @@ public class MapElementsTest implements Serializable {
public void testNestedPolymorphicSimpleFunction() throws Exception {
pipeline.enableAbandonedNodeEnforcement(false);
- PCollection<Integer> output =
- pipeline
- .apply(Create.of(1, 2, 3))
-
- // This is the function that needs to propagate the input T to
output T
- .apply("Polymorphic Identity", MapElements.via(new
NestedPolymorphicSimpleFunction<>()))
+ pipeline
+ .apply(Create.of(1, 2, 3))
- // This is a consumer to ensure that all coder inference logic is
executed.
- .apply(
- "Test Consumer",
- MapElements.via(
- new SimpleFunction<KV<Integer, String>, Integer>() {
- @Override
- public Integer apply(KV<Integer, String> input) {
- return 42;
- }
- }));
+ // This is the function that needs to propagate the input T to output T
+ .apply("Polymorphic Identity", MapElements.via(new
NestedPolymorphicSimpleFunction<>()))
+
+ // This is a consumer to ensure that all coder inference logic is
executed.
+ .apply(
+ "Test Consumer",
+ MapElements.via(
+ new SimpleFunction<KV<Integer, String>, Integer>() {
+ @Override
+ public Integer apply(KV<Integer, String> input) {
+ return 42;
+ }
+ }));
}
/**
diff --git
a/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/ParDoTest.java
b/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/ParDoTest.java
index 1287e35..3af16fe 100644
--- a/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/ParDoTest.java
+++ b/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/ParDoTest.java
@@ -3003,7 +3003,7 @@ public class ParDoTest implements Serializable {
public void onTimer() {}
};
- PCollection<Integer> output = pipeline.apply(Create.of(KV.of("hello",
37))).apply(ParDo.of(fn));
+ pipeline.apply(Create.of(KV.of("hello", 37))).apply(ParDo.of(fn));
thrown.expect(RuntimeException.class);
// Note that runners can reasonably vary their message - this matcher
should be flexible
// and can be evolved.
@@ -3033,7 +3033,7 @@ public class ParDoTest implements Serializable {
public void onTimer() {}
};
- PCollection<Integer> output = pipeline.apply(Create.of(KV.of("hello",
37))).apply(ParDo.of(fn));
+ pipeline.apply(Create.of(KV.of("hello", 37))).apply(ParDo.of(fn));
thrown.expect(RuntimeException.class);
// Note that runners can reasonably vary their message - this matcher
should be flexible
// and can be evolved.
diff --git
a/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/SimpleFunctionTest.java
b/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/SimpleFunctionTest.java
index 4fcaea3..0394b59 100644
---
a/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/SimpleFunctionTest.java
+++
b/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/SimpleFunctionTest.java
@@ -42,7 +42,7 @@ public class SimpleFunctionTest {
thrown.expectMessage("must override");
thrown.expectMessage("apply");
- SimpleFunction<Integer, Integer> broken = new SimpleFunction<Integer,
Integer>() {};
+ new SimpleFunction<Integer, Integer>() {};
}
/**
diff --git
a/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/reflect/DoFnSignaturesTest.java
b/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/reflect/DoFnSignaturesTest.java
index 0d5f7f3..f3c615a 100644
---
a/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/reflect/DoFnSignaturesTest.java
+++
b/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/reflect/DoFnSignaturesTest.java
@@ -279,15 +279,14 @@ public class DoFnSignaturesTest {
thrown.expectMessage("my-id");
thrown.expectMessage(not(mentionsState()));
thrown.expectMessage(mentionsTimers());
- DoFnSignature sig =
- DoFnSignatures.getSignature(
- new DoFn<KV<String, Integer>, Long>() {
- @TimerId("my-id")
- private final TimerSpec myfield1 =
TimerSpecs.timer(TimeDomain.EVENT_TIME);
+ DoFnSignatures.getSignature(
+ new DoFn<KV<String, Integer>, Long>() {
+ @TimerId("my-id")
+ private final TimerSpec myfield1 =
TimerSpecs.timer(TimeDomain.EVENT_TIME);
- @ProcessElement
- public void foo(ProcessContext context) {}
- }.getClass());
+ @ProcessElement
+ public void foo(ProcessContext context) {}
+ }.getClass());
}
@Test
@@ -299,15 +298,14 @@ public class DoFnSignaturesTest {
thrown.expectMessage("my-id");
thrown.expectMessage(not(mentionsState()));
thrown.expectMessage(mentionsTimers());
- DoFnSignature sig =
- DoFnSignatures.getSignature(
- new DoFn<KV<String, Integer>, Long>() {
- @OnTimer("my-id")
- public void onFoo() {}
+ DoFnSignatures.getSignature(
+ new DoFn<KV<String, Integer>, Long>() {
+ @OnTimer("my-id")
+ public void onFoo() {}
- @ProcessElement
- public void foo(ProcessContext context) {}
- }.getClass());
+ @ProcessElement
+ public void foo(ProcessContext context) {}
+ }.getClass());
}
@Test
@@ -335,7 +333,7 @@ public class DoFnSignaturesTest {
thrown.expectMessage(fn.getClass().getSimpleName());
thrown.expectMessage(not(mentionsState()));
thrown.expectMessage(mentionsTimers());
- DoFnSignature sig = DoFnSignatures.getSignature(fn.getClass());
+ DoFnSignatures.getSignature(fn.getClass());
}
@Test
@@ -346,14 +344,13 @@ public class DoFnSignaturesTest {
thrown.expectMessage(DoFnDeclaringTimerAndCallback.TIMER_ID);
thrown.expectMessage(not(mentionsState()));
thrown.expectMessage(mentionsTimers());
- DoFnSignature sig =
- DoFnSignatures.getSignature(
- new DoFnDeclaringTimerAndCallback() {
- @ProcessElement
- public void process(
- ProcessContext context,
- @TimerId(DoFnDeclaringTimerAndCallback.TIMER_ID) Timer
timer) {}
- }.getClass());
+ DoFnSignatures.getSignature(
+ new DoFnDeclaringTimerAndCallback() {
+ @ProcessElement
+ public void process(
+ ProcessContext context,
+ @TimerId(DoFnDeclaringTimerAndCallback.TIMER_ID) Timer timer) {}
+ }.getClass());
}
@Test
@@ -364,21 +361,20 @@ public class DoFnSignaturesTest {
thrown.expectMessage("myProcessElement");
thrown.expectMessage("index 2");
thrown.expectMessage(not(mentionsState()));
- DoFnSignature sig =
- DoFnSignatures.getSignature(
- new DoFn<KV<String, Integer>, Long>() {
- @TimerId("my-id")
- private final TimerSpec myfield =
TimerSpecs.timer(TimeDomain.PROCESSING_TIME);
+ DoFnSignatures.getSignature(
+ new DoFn<KV<String, Integer>, Long>() {
+ @TimerId("my-id")
+ private final TimerSpec myfield =
TimerSpecs.timer(TimeDomain.PROCESSING_TIME);
- @ProcessElement
- public void myProcessElement(
- ProcessContext context,
- @TimerId("my-id") Timer one,
- @TimerId("my-id") Timer two) {}
+ @ProcessElement
+ public void myProcessElement(
+ ProcessContext context,
+ @TimerId("my-id") Timer one,
+ @TimerId("my-id") Timer two) {}
- @OnTimer("my-id")
- public void onWhatever() {}
- }.getClass());
+ @OnTimer("my-id")
+ public void onWhatever() {}
+ }.getClass());
}
@Test
@@ -389,15 +385,14 @@ public class DoFnSignaturesTest {
thrown.expectMessage(DoFnWithOnlyCallback.TIMER_ID);
thrown.expectMessage(not(mentionsState()));
thrown.expectMessage(mentionsTimers());
- DoFnSignature sig =
- DoFnSignatures.getSignature(
- new DoFnWithOnlyCallback() {
- @TimerId(DoFnWithOnlyCallback.TIMER_ID)
- private final TimerSpec myfield1 =
TimerSpecs.timer(TimeDomain.EVENT_TIME);
+ DoFnSignatures.getSignature(
+ new DoFnWithOnlyCallback() {
+ @TimerId(DoFnWithOnlyCallback.TIMER_ID)
+ private final TimerSpec myfield1 =
TimerSpecs.timer(TimeDomain.EVENT_TIME);
- @ProcessElement
- public void foo(ProcessContext context) {}
- }.getClass());
+ @ProcessElement
+ public void foo(ProcessContext context) {}
+ }.getClass());
}
@Test
@@ -523,18 +518,17 @@ public class DoFnSignaturesTest {
thrown.expectMessage("myfield2");
thrown.expectMessage(not(containsString("State"))); // lowercase "state"
is in the package name
thrown.expectMessage(mentionsTimers());
- DoFnSignature sig =
- DoFnSignatures.getSignature(
- new DoFn<KV<String, Integer>, Long>() {
- @TimerId("my-id")
- private final TimerSpec myfield1 =
TimerSpecs.timer(TimeDomain.EVENT_TIME);
+ DoFnSignatures.getSignature(
+ new DoFn<KV<String, Integer>, Long>() {
+ @TimerId("my-id")
+ private final TimerSpec myfield1 =
TimerSpecs.timer(TimeDomain.EVENT_TIME);
- @TimerId("my-id")
- private final TimerSpec myfield2 =
TimerSpecs.timer(TimeDomain.EVENT_TIME);
+ @TimerId("my-id")
+ private final TimerSpec myfield2 =
TimerSpecs.timer(TimeDomain.EVENT_TIME);
- @ProcessElement
- public void foo(ProcessContext context) {}
- }.getClass());
+ @ProcessElement
+ public void foo(ProcessContext context) {}
+ }.getClass());
}
@Test
@@ -545,15 +539,14 @@ public class DoFnSignaturesTest {
thrown.expectMessage("myfield");
thrown.expectMessage(not(containsString("State"))); // lowercase "state"
is in the package name
thrown.expectMessage(mentionsTimers());
- DoFnSignature sig =
- DoFnSignatures.getSignature(
- new DoFn<KV<String, Integer>, Long>() {
- @TimerId("my-timer-id")
- private TimerSpec myfield =
TimerSpecs.timer(TimeDomain.PROCESSING_TIME);
+ DoFnSignatures.getSignature(
+ new DoFn<KV<String, Integer>, Long>() {
+ @TimerId("my-timer-id")
+ private TimerSpec myfield =
TimerSpecs.timer(TimeDomain.PROCESSING_TIME);
- @ProcessElement
- public void foo(ProcessContext context) {}
- }.getClass());
+ @ProcessElement
+ public void foo(ProcessContext context) {}
+ }.getClass());
}
@Test
@@ -611,18 +604,17 @@ public class DoFnSignaturesTest {
thrown.expectMessage("@" + DoFn.ProcessElement.class.getSimpleName());
thrown.expectMessage(DoFn.OnTimerContext.class.getSimpleName());
- DoFnSignature sig =
- DoFnSignatures.getSignature(
- new DoFn<KV<String, Integer>, Long>() {
- @TimerId("foo")
- private final TimerSpec bizzle =
TimerSpecs.timer(TimeDomain.EVENT_TIME);
+ DoFnSignatures.getSignature(
+ new DoFn<KV<String, Integer>, Long>() {
+ @TimerId("foo")
+ private final TimerSpec bizzle =
TimerSpecs.timer(TimeDomain.EVENT_TIME);
- @ProcessElement
- public void foo(ProcessContext context, OnTimerContext bogus) {}
+ @ProcessElement
+ public void foo(ProcessContext context, OnTimerContext bogus) {}
- @OnTimer("foo")
- public void onFoo() {}
- }.getClass());
+ @OnTimer("foo")
+ public void onFoo() {}
+ }.getClass());
}
@Test
@@ -698,16 +690,15 @@ public class DoFnSignaturesTest {
thrown.expectMessage("Non-final field");
thrown.expectMessage("myfield");
thrown.expectMessage(not(mentionsTimers()));
- DoFnSignature sig =
- DoFnSignatures.getSignature(
- new DoFn<KV<String, Integer>, Long>() {
- @StateId("my-id")
- private StateSpec<ValueState<Integer>> myfield =
- StateSpecs.value(VarIntCoder.of());
+ DoFnSignatures.getSignature(
+ new DoFn<KV<String, Integer>, Long>() {
+ @StateId("my-id")
+ private StateSpec<ValueState<Integer>> myfield =
+ StateSpecs.value(VarIntCoder.of());
- @ProcessElement
- public void foo(ProcessContext context) {}
- }.getClass());
+ @ProcessElement
+ public void foo(ProcessContext context) {}
+ }.getClass());
}
@Test
@@ -717,13 +708,12 @@ public class DoFnSignaturesTest {
thrown.expectMessage("myProcessElement");
thrown.expectMessage("index 1");
thrown.expectMessage(not(mentionsTimers()));
- DoFnSignature sig =
- DoFnSignatures.getSignature(
- new DoFn<KV<String, Integer>, Long>() {
- @ProcessElement
- public void myProcessElement(
- ProcessContext context, ValueState<Integer> noAnnotation) {}
- }.getClass());
+ DoFnSignatures.getSignature(
+ new DoFn<KV<String, Integer>, Long>() {
+ @ProcessElement
+ public void myProcessElement(
+ ProcessContext context, ValueState<Integer> noAnnotation) {}
+ }.getClass());
}
@Test
@@ -734,13 +724,12 @@ public class DoFnSignaturesTest {
thrown.expectMessage("myProcessElement");
thrown.expectMessage("index 1");
thrown.expectMessage(not(mentionsTimers()));
- DoFnSignature sig =
- DoFnSignatures.getSignature(
- new DoFn<KV<String, Integer>, Long>() {
- @ProcessElement
- public void myProcessElement(
- ProcessContext context, @StateId("my-id")
ValueState<Integer> undeclared) {}
- }.getClass());
+ DoFnSignatures.getSignature(
+ new DoFn<KV<String, Integer>, Long>() {
+ @ProcessElement
+ public void myProcessElement(
+ ProcessContext context, @StateId("my-id") ValueState<Integer>
undeclared) {}
+ }.getClass());
}
@Test
@@ -751,19 +740,18 @@ public class DoFnSignaturesTest {
thrown.expectMessage("myProcessElement");
thrown.expectMessage("index 2");
thrown.expectMessage(not(mentionsTimers()));
- DoFnSignature sig =
- DoFnSignatures.getSignature(
- new DoFn<KV<String, Integer>, Long>() {
- @StateId("my-id")
- private final StateSpec<ValueState<Integer>> myfield =
- StateSpecs.value(VarIntCoder.of());
+ DoFnSignatures.getSignature(
+ new DoFn<KV<String, Integer>, Long>() {
+ @StateId("my-id")
+ private final StateSpec<ValueState<Integer>> myfield =
+ StateSpecs.value(VarIntCoder.of());
- @ProcessElement
- public void myProcessElement(
- ProcessContext context,
- @StateId("my-id") ValueState<Integer> one,
- @StateId("my-id") ValueState<Integer> two) {}
- }.getClass());
+ @ProcessElement
+ public void myProcessElement(
+ ProcessContext context,
+ @StateId("my-id") ValueState<Integer> one,
+ @StateId("my-id") ValueState<Integer> two) {}
+ }.getClass());
}
@Test
@@ -777,17 +765,16 @@ public class DoFnSignaturesTest {
thrown.expectMessage("myProcessElement");
thrown.expectMessage("index 1");
thrown.expectMessage(not(mentionsTimers()));
- DoFnSignature sig =
- DoFnSignatures.getSignature(
- new DoFn<KV<String, Integer>, Long>() {
- @StateId("my-id")
- private final StateSpec<ValueState<Integer>> myfield =
- StateSpecs.value(VarIntCoder.of());
+ DoFnSignatures.getSignature(
+ new DoFn<KV<String, Integer>, Long>() {
+ @StateId("my-id")
+ private final StateSpec<ValueState<Integer>> myfield =
+ StateSpecs.value(VarIntCoder.of());
- @ProcessElement
- public void myProcessElement(
- ProcessContext context, @StateId("my-id") WatermarkHoldState
watermark) {}
- }.getClass());
+ @ProcessElement
+ public void myProcessElement(
+ ProcessContext context, @StateId("my-id") WatermarkHoldState
watermark) {}
+ }.getClass());
}
@Test
@@ -801,17 +788,16 @@ public class DoFnSignaturesTest {
thrown.expectMessage("myProcessElement");
thrown.expectMessage("index 1");
thrown.expectMessage(not(mentionsTimers()));
- DoFnSignature sig =
- DoFnSignatures.getSignature(
- new DoFn<KV<String, Integer>, Long>() {
- @StateId("my-id")
- private final StateSpec<ValueState<Integer>> myfield =
- StateSpecs.value(VarIntCoder.of());
+ DoFnSignatures.getSignature(
+ new DoFn<KV<String, Integer>, Long>() {
+ @StateId("my-id")
+ private final StateSpec<ValueState<Integer>> myfield =
+ StateSpecs.value(VarIntCoder.of());
- @ProcessElement
- public void myProcessElement(
- ProcessContext context, @StateId("my-id") ValueState<String>
stringState) {}
- }.getClass());
+ @ProcessElement
+ public void myProcessElement(
+ ProcessContext context, @StateId("my-id") ValueState<String>
stringState) {}
+ }.getClass());
}
@Test
@@ -865,7 +851,7 @@ public class DoFnSignaturesTest {
thrown.expectMessage("declared in a different class");
thrown.expectMessage(DoFnDeclaringState.STATE_ID);
thrown.expectMessage(fn.getClass().getSimpleName());
- DoFnSignature sig = DoFnSignatures.getSignature(fn.getClass());
+ DoFnSignatures.getSignature(fn.getClass());
}
@Test
@@ -874,13 +860,12 @@ public class DoFnSignaturesTest {
thrown.expectMessage("process");
thrown.expectMessage("declared in a different class");
thrown.expectMessage(DoFnUsingState.STATE_ID);
- DoFnSignature sig =
- DoFnSignatures.getSignature(
- new DoFnUsingState() {
- @StateId(DoFnUsingState.STATE_ID)
- private final StateSpec<ValueState<Integer>> spec =
- StateSpecs.value(VarIntCoder.of());
- }.getClass());
+ DoFnSignatures.getSignature(
+ new DoFnUsingState() {
+ @StateId(DoFnUsingState.STATE_ID)
+ private final StateSpec<ValueState<Integer>> spec =
+ StateSpecs.value(VarIntCoder.of());
+ }.getClass());
}
@Test
diff --git
a/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/windowing/WindowTest.java
b/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/windowing/WindowTest.java
index c3a756e..62549bf 100644
---
a/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/windowing/WindowTest.java
+++
b/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/windowing/WindowTest.java
@@ -35,12 +35,10 @@ import java.io.IOException;
import java.io.InputStream;
import java.io.OutputStream;
import java.io.Serializable;
-import java.util.ArrayList;
import java.util.Collection;
import java.util.Collections;
import java.util.HashMap;
import java.util.HashSet;
-import java.util.List;
import java.util.Map;
import java.util.Objects;
import java.util.Set;
@@ -416,12 +414,11 @@ public class WindowTest implements Serializable {
// same windows with the updated timestamps. If we try to apply the
original WindowFn, the type
// will not be appropriate and the runner should crash, as a Boolean
cannot be converted into
// a long.
- PCollection<Boolean> updatedTrigger =
- upOne.apply(
- "UpdateWindowingStrategy",
- Window.<Boolean>configure().triggering(Never.ever())
- .withAllowedLateness(Duration.ZERO)
- .accumulatingFiredPanes());
+ upOne.apply(
+ "UpdateWindowingStrategy",
+ Window.<Boolean>configure().triggering(Never.ever())
+ .withAllowedLateness(Duration.ZERO)
+ .accumulatingFiredPanes());
pipeline.run();
}
@@ -600,7 +597,6 @@ public class WindowTest implements Serializable {
@Category({ValidatesRunner.class, UsesCustomWindowMerging.class})
public void testMergingCustomWindows() {
Instant startInstant = new Instant(0L);
- List<TimestampedValue<String>> input = new ArrayList<>();
PCollection<String> inputCollection =
pipeline.apply(
Create.timestamped(
diff --git
a/sdks/java/extensions/jackson/src/test/java/org/apache/beam/sdk/extensions/jackson/JacksonTransformsTest.java
b/sdks/java/extensions/jackson/src/test/java/org/apache/beam/sdk/extensions/jackson/JacksonTransformsTest.java
index 5867f3a..c7c500d 100644
---
a/sdks/java/extensions/jackson/src/test/java/org/apache/beam/sdk/extensions/jackson/JacksonTransformsTest.java
+++
b/sdks/java/extensions/jackson/src/test/java/org/apache/beam/sdk/extensions/jackson/JacksonTransformsTest.java
@@ -145,10 +145,9 @@ public class JacksonTransformsTest {
@Test(expected = Pipeline.PipelineExecutionException.class)
public void failWritingWithoutCustomMapper() {
- PCollection<String> output =
- pipeline
- .apply(Create.of(EMPTY_BEANS))
-
.apply(AsJsons.of(MyEmptyBean.class)).setCoder(StringUtf8Coder.of());
+ pipeline
+ .apply(Create.of(EMPTY_BEANS))
+ .apply(AsJsons.of(MyEmptyBean.class)).setCoder(StringUtf8Coder.of());
pipeline.run();
}
diff --git
a/sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/BeamSqlDslFilterTest.java
b/sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/BeamSqlDslFilterTest.java
index 66bd1f1..3c1d310 100644
---
a/sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/BeamSqlDslFilterTest.java
+++
b/sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/BeamSqlDslFilterTest.java
@@ -120,9 +120,8 @@ public class BeamSqlDslFilterTest extends BeamSqlDslBase {
String sql = "SELECT * FROM TABLE_B WHERE f_int < 1";
- PCollection<Row> result =
- PCollectionTuple.of(new TupleTag<>("TABLE_A"), boundedInput1)
- .apply("testFromInvalidTableName1", BeamSql.query(sql));
+ PCollectionTuple.of(new TupleTag<>("TABLE_A"), boundedInput1)
+ .apply("testFromInvalidTableName1", BeamSql.query(sql));
pipeline.run().waitUntilFinish();
}
@@ -138,7 +137,7 @@ public class BeamSqlDslFilterTest extends BeamSqlDslBase {
String sql = "SELECT * FROM PCOLLECTION_NA";
- PCollection<Row> result = boundedInput1.apply(BeamSql.query(sql));
+ boundedInput1.apply(BeamSql.query(sql));
pipeline.run().waitUntilFinish();
}
@@ -151,7 +150,7 @@ public class BeamSqlDslFilterTest extends BeamSqlDslBase {
String sql = "SELECT * FROM PCOLLECTION WHERE f_int_na = 0";
- PCollection<Row> result = boundedInput1.apply(BeamSql.query(sql));
+ boundedInput1.apply(BeamSql.query(sql));
pipeline.run().waitUntilFinish();
}
diff --git
a/sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/impl/interpreter/BeamSqlFnExecutorTest.java
b/sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/impl/interpreter/BeamSqlFnExecutorTest.java
index 2114aa8..217982b 100644
---
a/sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/impl/interpreter/BeamSqlFnExecutorTest.java
+++
b/sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/impl/interpreter/BeamSqlFnExecutorTest.java
@@ -170,9 +170,7 @@ public class BeamSqlFnExecutorTest extends
BeamSqlFnExecutorTestBase {
@Test(expected = IllegalStateException.class)
public void testBuildExpression_logical_andOr_invalidOperand() {
- RexNode rexNode;
- BeamSqlExpression exp;
- rexNode = rexBuilder.makeCall(SqlStdOperatorTable.AND,
+ RexNode rexNode = rexBuilder.makeCall(SqlStdOperatorTable.AND,
Arrays.asList(
rexBuilder.makeLiteral(true),
rexBuilder.makeLiteral("hello")
@@ -183,9 +181,7 @@ public class BeamSqlFnExecutorTest extends
BeamSqlFnExecutorTestBase {
@Test(expected = IllegalStateException.class)
public void testBuildExpression_logical_not_invalidOperand() {
- RexNode rexNode;
- BeamSqlExpression exp;
- rexNode = rexBuilder.makeCall(SqlStdOperatorTable.NOT,
+ RexNode rexNode = rexBuilder.makeCall(SqlStdOperatorTable.NOT,
Arrays.asList(
rexBuilder.makeLiteral("hello")
)
@@ -196,9 +192,7 @@ public class BeamSqlFnExecutorTest extends
BeamSqlFnExecutorTestBase {
@Test(expected = IllegalStateException.class)
public void testBuildExpression_logical_not_invalidOperandCount() {
- RexNode rexNode;
- BeamSqlExpression exp;
- rexNode = rexBuilder.makeCall(SqlStdOperatorTable.NOT,
+ RexNode rexNode = rexBuilder.makeCall(SqlStdOperatorTable.NOT,
Arrays.asList(
rexBuilder.makeLiteral(true),
rexBuilder.makeLiteral(true)
diff --git
a/sdks/java/harness/src/test/java/org/apache/beam/fn/harness/logging/BeamFnLoggingClientTest.java
b/sdks/java/harness/src/test/java/org/apache/beam/fn/harness/logging/BeamFnLoggingClientTest.java
index cdc8139..716ab5f 100644
---
a/sdks/java/harness/src/test/java/org/apache/beam/fn/harness/logging/BeamFnLoggingClientTest.java
+++
b/sdks/java/harness/src/test/java/org/apache/beam/fn/harness/logging/BeamFnLoggingClientTest.java
@@ -167,7 +167,6 @@ public class BeamFnLoggingClientTest {
@Test
public void testWhenServerFailsThatClientIsAbleToCleanup() throws Exception {
- AtomicBoolean clientClosedStream = new AtomicBoolean();
Collection<BeamFnApi.LogEntry> values = new ConcurrentLinkedQueue<>();
AtomicReference<StreamObserver<BeamFnApi.LogControl>>
outboundServerObserver =
new AtomicReference<>();
@@ -218,7 +217,6 @@ public class BeamFnLoggingClientTest {
@Test
public void testWhenServerHangsUpEarlyThatClientIsAbleCleanup() throws
Exception {
- AtomicBoolean clientClosedStream = new AtomicBoolean();
Collection<BeamFnApi.LogEntry> values = new ConcurrentLinkedQueue<>();
AtomicReference<StreamObserver<BeamFnApi.LogControl>>
outboundServerObserver =
new AtomicReference<>();
diff --git
a/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/FakeDatasetService.java
b/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/FakeDatasetService.java
index d1b75d7..3526ed5 100644
---
a/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/FakeDatasetService.java
+++
b/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/FakeDatasetService.java
@@ -151,8 +151,7 @@ class FakeDatasetService implements DatasetService,
Serializable {
tableReference.getProjectId(),
tableReference.getDatasetId());
}
- TableContainer tableContainer =
- dataset.computeIfAbsent(tableReference.getTableId(), k -> new
TableContainer(table));
+ dataset.computeIfAbsent(tableReference.getTableId(), k -> new
TableContainer(table));
}
}
diff --git
a/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/datastore/DatastoreV1Test.java
b/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/datastore/DatastoreV1Test.java
index 672cb80..3a8a6a6 100644
---
a/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/datastore/DatastoreV1Test.java
+++
b/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/datastore/DatastoreV1Test.java
@@ -728,7 +728,7 @@ public class DatastoreV1Test {
ReadFn readFn = new ReadFn(V_1_OPTIONS, mockDatastoreFactory);
DoFnTester<Query, Entity> doFnTester = DoFnTester.of(readFn);
doFnTester.setCloningBehavior(CloningBehavior.DO_NOT_CLONE);
- List<Entity> entities = doFnTester.processBundle(query);
+ doFnTester.processBundle(query);
}
@Test
diff --git
a/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/pubsub/PubsubIOTest.java
b/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/pubsub/PubsubIOTest.java
index 6d92861..f13ed1e 100644
---
a/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/pubsub/PubsubIOTest.java
+++
b/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/pubsub/PubsubIOTest.java
@@ -38,7 +38,6 @@ import org.apache.beam.sdk.testing.UsesUnboundedPCollections;
import org.apache.beam.sdk.testing.ValidatesRunner;
import org.apache.beam.sdk.transforms.display.DisplayData;
import org.apache.beam.sdk.transforms.display.DisplayDataEvaluator;
-import org.joda.time.Duration;
import org.junit.Rule;
import org.junit.Test;
import org.junit.experimental.categories.Category;
@@ -97,8 +96,6 @@ public class PubsubIOTest {
@Test
public void testReadTopicDisplayData() {
String topic = "projects/project/topics/topic";
- String subscription = "projects/project/subscriptions/subscription";
- Duration maxReadTime = Duration.standardMinutes(5);
PubsubIO.Read<String> read = PubsubIO.readStrings()
.fromTopic(StaticValueProvider.of(topic))
.withTimestampAttribute("myTimestamp")
@@ -113,9 +110,7 @@ public class PubsubIOTest {
@Test
public void testReadSubscriptionDisplayData() {
- String topic = "projects/project/topics/topic";
String subscription = "projects/project/subscriptions/subscription";
- Duration maxReadTime = Duration.standardMinutes(5);
PubsubIO.Read<String> read = PubsubIO.readStrings()
.fromSubscription(StaticValueProvider.of(subscription))
.withTimestampAttribute("myTimestamp")
--
To stop receiving notification emails like this one, please contact
lc...@apache.org.
