[
https://issues.apache.org/jira/browse/BEAM-4131?focusedWorklogId=95691&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-95691
]
ASF GitHub Bot logged work on BEAM-4131:
----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Apr/18 18:19
Start Date: 26/Apr/18 18:19
Worklog Time Spent: 10m
Work Description: herohde commented on a change in pull request #5233:
[BEAM-4131] Include SDK into Python SDK harness container.
URL: https://github.com/apache/beam/pull/5233#discussion_r184484725
##########
File path: sdks/python/container/Dockerfile
##########
@@ -80,6 +80,10 @@ RUN \
# Check that the fast implementation of protobuf is used.
python -c "from google.protobuf.internal import api_implementation; assert
api_implementation._default_implementation_type == 'cpp'; print 'Verified fast
protobuf used.'"
+COPY target/apache-beam.tar.gz /opt/apache/beam/tars/
+RUN pip install /opt/apache/beam/tars/apache-beam.tar.gz[gcp] && \
+ rm /opt/apache/beam/tars/apache-beam.tar.gz
Review comment:
No need to delete the tar.gz. The image size will be the same.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 95691)
Time Spent: 0.5h (was: 20m)
> Python SDK harness container image contains SDK and dependencies
> ----------------------------------------------------------------
>
> Key: BEAM-4131
> URL: https://issues.apache.org/jira/browse/BEAM-4131
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-harness
> Reporter: Ben Sidhom
> Assignee: Thomas Weise
> Priority: Minor
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The Docker image for the SDK harness should contain SDK code and dependencies
> so that this does not need to be downloaded from the artifact retrieval
> service at each boot.
> This is required for operation with portable runners right now because the
> python client does not currently stage the SDK itself (as it does with the
> Dataflow runner).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
