[
https://issues.apache.org/jira/browse/BEAM-3303?focusedWorklogId=95748&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-95748
]
ASF GitHub Bot logged work on BEAM-3303:
----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Apr/18 22:08
Start Date: 26/Apr/18 22:08
Worklog Time Spent: 10m
Work Description: herohde commented on a change in pull request #5179:
[BEAM-3303] Add Go Windowing support
URL: https://github.com/apache/beam/pull/5179#discussion_r184545205
##########
File path: sdks/go/pkg/beam/core/runtime/exec/coder.go
##########
@@ -276,42 +277,135 @@ func (c *kvDecoder) Decode(r io.Reader) (FullValue,
error) {
}
-// TODO(herohde) 4/7/2017: actually handle windows.
+// WindowEncoder handles Window serialization to a byte stream. The encoder
+// can be reused, even if an error is encountered.
Review comment:
Added comment to all coding types that they are concurrency-safe.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 95748)
Time Spent: 4h 40m (was: 4.5h)
> Go windowing support
> --------------------
>
> Key: BEAM-3303
> URL: https://issues.apache.org/jira/browse/BEAM-3303
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go
> Reporter: Henning Rohde
> Assignee: Henning Rohde
> Priority: Major
> Time Spent: 4h 40m
> Remaining Estimate: 0h
>
> Add support for Window.into and windowing strategies on Node. Implement the
> various windowing strategies Beam has: GlobalWindow, FixedWindows, etc.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
