[ 
https://issues.apache.org/jira/browse/BEAM-4182?focusedWorklogId=96066&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-96066
 ]

ASF GitHub Bot logged work on BEAM-4182:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 27/Apr/18 13:09
            Start Date: 27/Apr/18 13:09
    Worklog Time Spent: 10m 
      Work Description: matzew opened a new pull request #5238: BEAM-4182 fix 
to allow JMSMessageId to be null
URL: https://github.com/apache/beam/pull/5238
 
 
   the `equals` assumes that JMSMessageID is always present, but the spec if 
fine to have this being null:
   
   >Message header field references are restricted to JMSDeliveryMode,
   JMSPriority, JMSMessageID, JMSTimestamp, JMSCorrelationID, and
   JMSType. JMSMessageID, JMSCorrelationID, and JMSType values may be
   null and if so are treated as a NULL value.
   
   
   ------------------------
   
   This PR removes the `jmsmessageID` from the `equals` since it can be 
actually null, see quoted SPEC text.
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

            Worklog Id:     (was: 96066)
            Time Spent: 10m
    Remaining Estimate: 0h

> JMSMessageID can be null
> ------------------------
>
>                 Key: BEAM-4182
>                 URL: https://issues.apache.org/jira/browse/BEAM-4182
>             Project: Beam
>          Issue Type: Bug
>          Components: io-java-jms
>    Affects Versions: 2.4.0
>            Reporter: Matthias Weßendorf
>            Assignee: Jean-Baptiste Onofré
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> JMSRecord asssumes the JMSMessageID to be not null, but spec says:
>  
> {quote}
> Message header field references are restricted to JMSDeliveryMode,
> JMSPriority, JMSMessageID, JMSTimestamp, JMSCorrelationID, and
> JMSType. JMSMessageID, JMSCorrelationID, and JMSType values may be
> null and if so are treated as a NULL value.
> {quote}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to