[
https://issues.apache.org/jira/browse/BEAM-4144?focusedWorklogId=97238&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-97238
]
ASF GitHub Bot logged work on BEAM-4144:
----------------------------------------
Author: ASF GitHub Bot
Created on: 01/May/18 21:37
Start Date: 01/May/18 21:37
Worklog Time Spent: 10m
Work Description: jkff closed pull request #5250: [BEAM-4144] Fixes
SplittableParDoProcessFnTest
URL: https://github.com/apache/beam/pull/5250
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/runners/core-java/src/test/java/org/apache/beam/runners/core/SplittableParDoProcessFnTest.java
b/runners/core-java/src/test/java/org/apache/beam/runners/core/SplittableParDoProcessFnTest.java
index 8ceee91852b..617e557c391 100644
---
a/runners/core-java/src/test/java/org/apache/beam/runners/core/SplittableParDoProcessFnTest.java
+++
b/runners/core-java/src/test/java/org/apache/beam/runners/core/SplittableParDoProcessFnTest.java
@@ -64,7 +64,6 @@
import org.apache.beam.sdk.values.WindowingStrategy;
import org.joda.time.Duration;
import org.joda.time.Instant;
-import org.junit.Ignore;
import org.junit.Rule;
import org.junit.Test;
import org.junit.runner.RunWith;
@@ -427,7 +426,7 @@ public ProcessContinuation process(ProcessContext c,
OffsetRangeTracker tracker)
for (long i = tracker.currentRestriction().getFrom(), numIterations = 0;
tracker.tryClaim(i); ++i, ++numIterations) {
c.output(String.valueOf(c.element() + i));
- if (numIterations == numOutputsPerCall) {
+ if (numIterations == numOutputsPerCall - 1) {
return resume();
}
}
@@ -441,7 +440,6 @@ public OffsetRange getInitialRestriction(Integer elem) {
}
@Test
- @Ignore("https://issues.apache.org/jira/browse/BEAM-4144";)
public void testResumeCarriesOverState() throws Exception {
DoFn<Integer, String> fn = new CounterFn(1);
Instant base = Instant.now();
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 97238)
Time Spent: 40m (was: 0.5h)
> SplittableParDoProcessFnTest has had a masked failure
> -----------------------------------------------------
>
> Key: BEAM-4144
> URL: https://issues.apache.org/jira/browse/BEAM-4144
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Kenneth Knowles
> Assignee: Eugene Kirpichov
> Priority: Major
> Labels: sickbay
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Sickbayed in https://github.com/apache/beam/pull/5161, the test should be
> fixed and no longer ignored.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
