[
https://issues.apache.org/jira/browse/BEAM-4031?focusedWorklogId=98042&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-98042
]
ASF GitHub Bot logged work on BEAM-4031:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/May/18 21:26
Start Date: 03/May/18 21:26
Worklog Time Spent: 10m
Work Description: herohde commented on a change in pull request #5272:
[BEAM-4031] Add labels flag to Go SDK Dataflow Runner.
URL: https://github.com/apache/beam/pull/5272#discussion_r185941021
##########
File path: sdks/go/pkg/beam/runners/dataflow/dataflow.go
##########
@@ -93,6 +94,12 @@ func Execute(ctx context.Context, p *beam.Pipeline) error {
if *image == "" {
*image = jobopts.GetContainerImage(ctx)
}
+ var jobLabels map[string]string
+ if *labels != "" {
+ if err := json.Unmarshal([]byte(*labels), &jobLabels); err !=
nil {
+ return err
Review comment:
return a descriptive error
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 98042)
Time Spent: 1.5h (was: 1h 20m)
> Add missing dataflow customization options for Go SDK
> -----------------------------------------------------
>
> Key: BEAM-4031
> URL: https://issues.apache.org/jira/browse/BEAM-4031
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go
> Reporter: Henning Rohde
> Assignee: Jason Kuster
> Priority: Minor
> Fix For: 2.5.0
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> We're missing at least:
> zone
> temp_location
> worker_machine_type
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
