[
https://issues.apache.org/jira/browse/BEAM-3119?focusedWorklogId=98152&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-98152
]
ASF GitHub Bot logged work on BEAM-3119:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/May/18 08:16
Start Date: 04/May/18 08:16
Worklog Time Spent: 10m
Work Description: echauchot commented on issue #4965: BEAM-3119 ensure
the metrics thread pool is related to an execution
URL: https://github.com/apache/beam/pull/4965#issuecomment-386533821
@swegner +1. I submitted a PR yesterday
(https://github.com/apache/beam/pull/5267) with a wait bounded to 10 min. But I
did not notice that the test was failing that fast, thanks for pointing out !
So my supposition about the hit of the timeout is wrong indeed. I guess it
makes my last PR useless. Besides I'm not convinced about the interest of
ensureMetricsThreadDoesntLeak test compared to the other test in the class.
I'll discuss more with Romain and merge a fix today.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 98152)
Time Spent: 5.5h (was: 5h 20m)
> direct-metrics-counter-committer threads are leaking
> ----------------------------------------------------
>
> Key: BEAM-3119
> URL: https://issues.apache.org/jira/browse/BEAM-3119
> Project: Beam
> Issue Type: Bug
> Components: runner-direct
> Reporter: Etienne Chauchot
> Assignee: Romain Manni-Bucau
> Priority: Major
> Fix For: 2.5.0
>
> Time Spent: 5.5h
> Remaining Estimate: 0h
>
> When I run ElasticsearchIOTests using ESv5, there is a thread leak control
> mechanism ({{com.carrotsearch.randomizedtesting.ThreadLeakControl}}). It
> waits for 5s for non-terminated threads at the end of a test. It detects
> leaked {{direct-metrics-counter-committer}} thread.
> {code}
> com.carrotsearch.randomizedtesting.ThreadLeakError: There are still zombie
> threads that couldn't be terminated:
> 1) Thread[id=296, name=direct-metrics-counter-committer,
> state=TIMED_WAITING, group=TGRP-ElasticsearchIOTest]
> at sun.misc.Unsafe.park(Native Method)
> at
> java.util.concurrent.locks.LockSupport.parkNanos(LockSupport.java:215)
> at
> java.util.concurrent.SynchronousQueue$TransferStack.awaitFulfill(SynchronousQueue.java:460)
> at
> java.util.concurrent.SynchronousQueue$TransferStack.transfer(SynchronousQueue.java:362)
> at
> java.util.concurrent.SynchronousQueue.poll(SynchronousQueue.java:941)
> at
> java.util.concurrent.ThreadPoolExecutor.getTask(ThreadPoolExecutor.java:1066)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1127)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> at __randomizedtesting.SeedInfo.seed([59E504CA1B0DD6A8]:0){code}
> I tried to increase the timeout to 30s (by patching
> randomizedtesting-runner-2.5.0.jar) but still gets a zombie thread.
> To reproduce, just comment
> {code}
> @ThreadLeakScope(ThreadLeakScope.Scope.NONE)
> {code}
> in
> {code}
> beam/sdks/java/io/elasticsearch-tests/elasticsearch-tests-5/src/test/java/org/apache/beam/sdk/io/elasticsearch/ElasticsearchIOTest.java
> {code}
> and run
> {code}
> testRead()
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
