[
https://issues.apache.org/jira/browse/BEAM-2597?focusedWorklogId=99307&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-99307
]
ASF GitHub Bot logged work on BEAM-2597:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/May/18 00:35
Start Date: 08/May/18 00:35
Worklog Time Spent: 10m
Work Description: bsidhom commented on a change in pull request #5285:
[BEAM-2597] Flink batch ExecutableStage operator
URL: https://github.com/apache/beam/pull/5285#discussion_r186585289
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkBundleFactory.java
##########
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.runners.flink;
+
+import org.apache.beam.runners.fnexecution.artifact.ArtifactSource;
+import org.apache.beam.runners.fnexecution.control.JobBundleFactory;
+import org.apache.beam.runners.fnexecution.provisioning.JobInfo;
+
+/**
+ * A simple {@link JobBundleFactory} for Flink operators. Uses Docker for
underlying environment
+ * management.
+ */
+public class FlinkBundleFactory {
+
+ public static FlinkBundleFactory getInstance() {
+ return Holder.INSTANCE;
+ }
+
+ /** Gets or creates a {@link JobBundleFactory}. */
+ public JobBundleFactory getJobBundleFactory(JobInfo jobInfo, ArtifactSource
artifactSource) {
+ throw new UnsupportedOperationException();
+ }
+
+ private static class Holder {
Review comment:
Removed.
Note: I originally thought this class might do more work and wanted lazy
initialization. However, given that the bundle factory itself must have
TaskManager-local state, this cannot be passed directly to the
`FlinkExecutableStage` at construction. Instead, any heavy lifting will happen
in the `SerializableSupplier` that produces this. `getInstance` will probably
change to return a `SerializableSupplier<FlinkBundleFactory>`. This is
effectively a FactoryFactory(FactoryFactoryFactory).
It's unfortunate we need this many layers of indirection for object
creation, but it's necessary for unit testing and distributed execution.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 99307)
Time Spent: 2h 20m (was: 2h 10m)
> FlinkRunner ExecutableStage batch operator
> ------------------------------------------
>
> Key: BEAM-2597
> URL: https://issues.apache.org/jira/browse/BEAM-2597
> Project: Beam
> Issue Type: Sub-task
> Components: runner-flink
> Reporter: Kenneth Knowles
> Assignee: Ben Sidhom
> Priority: Major
> Labels: portability
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> This operator will execute user code in the context of an SDK harness by
> constructing a ProcessBundleDescriptor from an ExecutableStage (physical
> stage plan) and sending instructions/elements over the control and data
> planes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
