[
https://issues.apache.org/jira/browse/BEAM-4162?focusedWorklogId=99575&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-99575
]
ASF GitHub Bot logged work on BEAM-4162:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/May/18 15:33
Start Date: 08/May/18 15:33
Worklog Time Spent: 10m
Work Description: kennknowles commented on a change in pull request
#5253: [BEAM-4162][SQL] Wire up PubsubIO to SQL
URL: https://github.com/apache/beam/pull/5253#discussion_r186771227
##########
File path: sdks/java/extensions/sql/build.gradle
##########
@@ -66,6 +66,7 @@ dependencies {
shadow library.java.joda_time
shadow project(path: ":beam-runners-direct-java", configuration: "shadow")
provided project(path: ":beam-sdks-java-io-kafka", configuration: "shadow")
+ provided project(path: ":beam-sdks-java-io-google-cloud-platform",
configuration: "shadow")
Review comment:
<!--new_thread; commit:bd86c968878f080c2d774f7485ae76ccc0534792;
resolved:1-->
In both the Kafka case and this case, doesn't `provided` force the user to
declare a dependency? It is not the same as "optional". We do need to revisit
this design so that connectors can be pluggable. Perhaps soon.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 99575)
Time Spent: 3h 50m (was: 3h 40m)
> Wire up PubsubIO+JSON to Beam SQL
> ---------------------------------
>
> Key: BEAM-4162
> URL: https://issues.apache.org/jira/browse/BEAM-4162
> Project: Beam
> Issue Type: New Feature
> Components: dsl-sql
> Reporter: Anton Kedin
> Assignee: Anton Kedin
> Priority: Major
> Time Spent: 3h 50m
> Remaining Estimate: 0h
>
> Read JSON messages from Pubsub, convert them to Rows (BEAM-4160), wire up to
> Beam SQL.
>
> Use publication time as event timestamp
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
