[
https://issues.apache.org/jira/browse/BEAM-3981?focusedWorklogId=99719&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-99719
]
ASF GitHub Bot logged work on BEAM-3981:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/May/18 20:50
Start Date: 08/May/18 20:50
Worklog Time Spent: 10m
Work Description: tvalentyn commented on issue #5053: [BEAM-3981]
Futurize coders subpackage
URL: https://github.com/apache/beam/pull/5053#issuecomment-387538220
@RobbeSneyders I think it's fine to make one-off exceptions for
coders_impl.py, and annotating them with inline exceptions from lint checker
for the two changes we discussed. We don't expect these kind of exceptions for
most other parts of codebase, but wanted to do our due diligence on this
package since it's on critical path.
I agree with you, let's remove the `range()` import. For `iteritems` how
about we do something along the lines:
```
if (...python 2...):
items = dict_value.iteritems() # no-py3lint: allow iteritems()
else:
items = dict_value.items()
for k,v in items:
...
```
I think with these changes we can proceed with the merge, I will do
benchmarking in parallel and we can clean this up later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 99719)
Time Spent: 16h (was: 15h 50m)
> Futurize and fix python 2 compatibility for coders package
> ----------------------------------------------------------
>
> Key: BEAM-3981
> URL: https://issues.apache.org/jira/browse/BEAM-3981
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Robbe
> Assignee: Robbe
> Priority: Major
> Time Spent: 16h
> Remaining Estimate: 0h
>
> Run automatic conversion with futurize tool on coders subpackage and fix
> python 2 compatibility. This prepares the subpackage for python 3 support.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
