[
https://issues.apache.org/jira/browse/BEAM-4204?focusedWorklogId=99781&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-99781
]
ASF GitHub Bot logged work on BEAM-4204:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/May/18 23:16
Start Date: 08/May/18 23:16
Worklog Time Spent: 10m
Work Description: angoenka commented on a change in pull request #5301:
[BEAM-4204] Splitting ULR in portable runner stub and job service
URL: https://github.com/apache/beam/pull/5301#discussion_r186891548
##########
File path:
sdks/python/apache_beam/runners/portability/universal_local_runner.py
##########
@@ -50,42 +37,30 @@
class UniversalLocalRunner(runner.PipelineRunner):
- """A BeamRunner that executes Python pipelines via the Beam Job API.
+ """
+ Experimental: No backward compatibility guaranteed.
+ A BeamRunner that executes Python pipelines via the Beam Job API.
- By default, this runner executes in process but still uses GRPC to
communicate
- pipeline and worker state. It can also be configured to use inline calls
- rather than GRPC (for speed) or launch completely separate subprocesses for
- the runner and worker(s).
+ This runner is a stub and does not run the actual job.
+ This runner schedules the job on a job service. The responsibility of
+ running and managing the job lies with the job service used.
"""
- def __init__(
- self,
- use_grpc=True,
- use_subprocesses=False,
- runner_api_address=None,
- docker_image=None):
- if use_subprocesses and not use_grpc:
- raise ValueError("GRPC must be used with subprocesses")
+ # TODO(angoenka): Read all init parameters from pipeline_options.
+ def __init__(self,
+ runner_api_address=None,
+ job_service_address=None,
Review comment:
Not sure, I need to check with @robertwb about the intent of
runner_api_address.
docker_image and other parameters in constructor should be moved to
pipeline_options as job_service will interpret them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 99781)
Time Spent: 1h 50m (was: 1h 40m)
> Python: PortableRunner - p.run() via given JobService
> -----------------------------------------------------
>
> Key: BEAM-4204
> URL: https://issues.apache.org/jira/browse/BEAM-4204
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
> Reporter: Eugene Kirpichov
> Assignee: Eugene Kirpichov
> Priority: Major
> Fix For: Not applicable
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Like BEAM-4071 but for Python. Is this fully encompassed by
> [https://github.com/apache/beam/blob/master/sdks/python/apache_beam/runners/portability/universal_local_runner.py]
> ?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
