[
https://issues.apache.org/jira/browse/BEAM-3981?focusedWorklogId=100309&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-100309
]
ASF GitHub Bot logged work on BEAM-3981:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/May/18 22:44
Start Date: 09/May/18 22:44
Worklog Time Spent: 10m
Work Description: robertwb commented on issue #5053: [BEAM-3981] Futurize
coders subpackage
URL: https://github.com/apache/beam/pull/5053#issuecomment-387897325
Regarding items vs. iteritems, let's just go with dict_value.items
everywhere. There's little if any need for explicit iteritems in this case (and
if dict is typed, I think Cython optimizes `for k, v in dict_value.items()`
optimally without the intermediate list anyways).
Though macrobenchmarks can be good for final validation, this is the kind of
code that could probably benefit from some pretty simple microbenchmarks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 100309)
Time Spent: 18h (was: 17h 50m)
> Futurize and fix python 2 compatibility for coders package
> ----------------------------------------------------------
>
> Key: BEAM-3981
> URL: https://issues.apache.org/jira/browse/BEAM-3981
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Robbe
> Assignee: Robbe
> Priority: Major
> Time Spent: 18h
> Remaining Estimate: 0h
>
> Run automatic conversion with futurize tool on coders subpackage and fix
> python 2 compatibility. This prepares the subpackage for python 3 support.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
