[
https://issues.apache.org/jira/browse/BEAM-4251?focusedWorklogId=100313&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-100313
]
ASF GitHub Bot logged work on BEAM-4251:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/May/18 22:49
Start Date: 09/May/18 22:49
Worklog Time Spent: 10m
Work Description: kennknowles closed pull request #5292: [BEAM-4251] Fix
broken javadoc ref
URL: https://github.com/apache/beam/pull/5292
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rule/BeamEnumerableConverterRule.java
b/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rule/BeamEnumerableConverterRule.java
index aceaedd5271..501fc0202dd 100644
---
a/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rule/BeamEnumerableConverterRule.java
+++
b/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rule/BeamEnumerableConverterRule.java
@@ -19,13 +19,14 @@
import org.apache.beam.sdk.extensions.sql.impl.rel.BeamEnumerableConverter;
import org.apache.beam.sdk.extensions.sql.impl.rel.BeamLogicalConvention;
+import org.apache.beam.sdk.extensions.sql.impl.rel.BeamRelNode;
import org.apache.calcite.adapter.enumerable.EnumerableConvention;
import org.apache.calcite.plan.RelTraitSet;
import org.apache.calcite.rel.RelNode;
import org.apache.calcite.rel.convert.ConverterRule;
/**
- * A {@code ConverterRule} to Convert {@link BeamRel} to {@link
EnumerableConvention}.
+ * A {@code ConverterRule} to Convert {@link BeamRelNode} to {@link
EnumerableConvention}.
*
*/
public class BeamEnumerableConverterRule extends ConverterRule {
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 100313)
Time Spent: 50m (was: 40m)
> SQL javadoc has broken ref
> --------------------------
>
> Key: BEAM-4251
> URL: https://issues.apache.org/jira/browse/BEAM-4251
> Project: Beam
> Issue Type: Bug
> Components: dsl-sql
> Reporter: Kenneth Knowles
> Assignee: Andrew Pilloud
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Looks like an import. I know with Maven we had an iffy relationship between
> IWYU analysis and Javadoc. I think for toplevel classes you should be fine.
> And I don't know if Gradle has parity here anyhow.
> https://scans.gradle.com/s/kb3xglt4v47ti/console-log?task=:beam-sdks-java-extensions-sql:javadoc#L285
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
