[
https://issues.apache.org/jira/browse/BEAM-2588?focusedWorklogId=100788&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-100788
]
ASF GitHub Bot logged work on BEAM-2588:
----------------------------------------
Author: ASF GitHub Bot
Created on: 10/May/18 19:43
Start Date: 10/May/18 19:43
Worklog Time Spent: 10m
Work Description: axelmagn commented on a change in pull request #5262:
[BEAM-2588] WIP Portability Runner Job Service
URL: https://github.com/apache/beam/pull/5262#discussion_r187437816
##########
File path:
runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/artifact/ArtifactStagingService.java
##########
@@ -0,0 +1,32 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.beam.runners.fnexecution.artifact;
+
+import org.apache.beam.runners.fnexecution.FnService;
+
+/** An implementation of the Beam Artifact Staging Service. */
+public interface ArtifactStagingService extends FnService {
Review comment:
That is indeed intended. There are 2 expected users: the client uploading
artifacts during job submission, and the runner retrieving those artifacts for
distribution to workers. So once we upload the artifacts we need to
communicate them to the runner somehow, and this is done through the
createAccessor method. The alternative was to a) create a separate interface
for createAccessor(),and b) then create a third interface that extends both
ArtifactStagingService and interface (a). However, since getting access to the
artifacts once they are staged is a reasonable expectation to put on the
ArtifactStagingService, I chose to just add that method to the existing
interface.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 100788)
Time Spent: 1h 10m (was: 1h)
> Portable Flink Runner Job API
> -----------------------------
>
> Key: BEAM-2588
> URL: https://issues.apache.org/jira/browse/BEAM-2588
> Project: Beam
> Issue Type: New Feature
> Components: runner-flink
> Reporter: Kenneth Knowles
> Assignee: Axel Magnuson
> Priority: Major
> Labels: portability
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> The portable Flink runner needs to be wired into a job server so that it can
> accept jobs the job api (https://s.apache.org/beam-job-api).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
