[
https://issues.apache.org/jira/browse/BEAM-4269?focusedWorklogId=100880&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-100880
]
ASF GitHub Bot logged work on BEAM-4269:
----------------------------------------
Author: ASF GitHub Bot
Created on: 10/May/18 22:32
Start Date: 10/May/18 22:32
Worklog Time Spent: 10m
Work Description: tgroh commented on a change in pull request #5329:
[BEAM-4269, BEAM-3970] Implement AssignWindows in the Java SDK harness
URL: https://github.com/apache/beam/pull/5329#discussion_r187448842
##########
File path:
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/MapFnRunner.java
##########
@@ -45,31 +45,45 @@
* <p>Simple map functions are used in a large number of transforms,
especially runner-managed
* transforms, such as map_windows.
*
- * <p>TODO: Add support for DoFns which are actually user supplied map/lambda
functions instead
- * of using the {@link FnApiDoFnRunner} instance.
+ * <p>TODO: Add support for DoFns which are actually user supplied map/lambda
functions instead of
+ * using the {@link FnApiDoFnRunner} instance.
*/
public class MapFnRunner<InputT, OutputT> {
- public static <InputT, OutputT> PTransformRunnerFactory<?>
- createMapFnRunnerFactoryWith(
- CreateMapFunctionForPTransform<InputT, OutputT> fnFactory) {
+ public static <InputT, OutputT> PTransformRunnerFactory<?>
forValueMapFnFactory(
+ ValueMapFnFactory<InputT, OutputT> fnFactory) {
+ return forMapFnFactory(new
ValueOnlyWindowedValueMapFnFactory<>(fnFactory));
+ }
+
+ public static <InputT, OutputT> PTransformRunnerFactory<?> forMapFnFactory(
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 100880)
Time Spent: 2h (was: 1h 50m)
> Implement Assign Windows in the Java SDK Harness
> ------------------------------------------------
>
> Key: BEAM-4269
> URL: https://issues.apache.org/jira/browse/BEAM-4269
> Project: Beam
> Issue Type: New Feature
> Components: sdk-java-harness
> Reporter: Thomas Groh
> Assignee: Thomas Groh
> Priority: Major
> Fix For: Not applicable
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> This allows execution of Java WindowFns over the Fn API
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
