[
https://issues.apache.org/jira/browse/BEAM-4005?focusedWorklogId=101449&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-101449
]
ASF GitHub Bot logged work on BEAM-4005:
----------------------------------------
Author: ASF GitHub Bot
Created on: 12/May/18 10:09
Start Date: 12/May/18 10:09
Worklog Time Spent: 10m
Work Description: RobbeSneyders commented on a change in pull request
#5343: [BEAM-4005] Futurize tools subpackage
URL: https://github.com/apache/beam/pull/5343#discussion_r187769527
##########
File path: sdks/python/apache_beam/tools/distribution_counter_microbenchmark.py
##########
@@ -23,11 +23,16 @@
python -m apache_beam.tools.distribution_counter_microbenchmark
"""
+from __future__ import absolute_import
+from __future__ import division
from __future__ import print_function
import random
import sys
import time
+from builtins import range
+
+from past.utils import old_div
Review comment:
Can you replace old_div with the new Python 3 division? Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 101449)
Time Spent: 20m (was: 10m)
> Futurize and fix python 2 compatibility for tools subpackage
> ------------------------------------------------------------
>
> Key: BEAM-4005
> URL: https://issues.apache.org/jira/browse/BEAM-4005
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Robbe
> Assignee: Matthias Feys
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)