[
https://issues.apache.org/jira/browse/BEAM-3883?focusedWorklogId=102342&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-102342
]
ASF GitHub Bot logged work on BEAM-3883:
----------------------------------------
Author: ASF GitHub Bot
Created on: 15/May/18 23:07
Start Date: 15/May/18 23:07
Worklog Time Spent: 10m
Work Description: tvalentyn commented on issue #5251: [BEAM-3883]
Refactor and clean dependency.py to make it reusable with artifact service
URL: https://github.com/apache/beam/pull/5251#issuecomment-389342407
In my opinion, will be easier to follow and maintain the helper functions if
we explicitly remove the access to the state of the objects (`self`) when it is
not needed. I would argue, we should at least make them `@staticmethods`. From
that point on, the difference between a helper function in the module or a
private static method that does not access the class, is rather syntactic. I
think it's a little more overhead to have them as static methods, but I don't
mind that if you feel strongly about associating the helpers with the `Stager`
class.
You could also declare helper functions as inner functions of class methods
that need them, if they are only used in that particular method. I would
consider that for short helper functions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 102342)
Time Spent: 9h 50m (was: 9h 40m)
> Python SDK stages artifacts when talking to job server
> ------------------------------------------------------
>
> Key: BEAM-3883
> URL: https://issues.apache.org/jira/browse/BEAM-3883
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Ben Sidhom
> Assignee: Ankur Goenka
> Priority: Major
> Time Spent: 9h 50m
> Remaining Estimate: 0h
>
> The Python SDK does not currently stage its user-defined functions or
> dependencies when talking to the job API. Artifacts that need to be staged
> include the user code itself, any SDK components not included in the
> container image, and the list of Python packages that must be installed at
> runtime.
>
> Artifacts that are currently expected can be found in the harness boot code:
> [https://github.com/apache/beam/blob/58e3b06bee7378d2d8db1c8dd534b415864f63e1/sdks/python/container/boot.go#L52.]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
