[
https://issues.apache.org/jira/browse/BEAM-4199?focusedWorklogId=102615&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-102615
]
ASF GitHub Bot logged work on BEAM-4199:
----------------------------------------
Author: ASF GitHub Bot
Created on: 16/May/18 19:11
Start Date: 16/May/18 19:11
Worklog Time Spent: 10m
Work Description: kennknowles commented on a change in pull request
#5380: [BEAM-4199][SQL] Add support for DLQ to PubsubJsonTable
URL: https://github.com/apache/beam/pull/5380#discussion_r188740212
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/TestPubsubSignal.java
##########
@@ -112,6 +112,7 @@ private void initializePubsub(Description description)
throws IOException {
//
integ-test-TestClassName-testMethodName-2018-12-11-23-32-333-<random-long>-result
String resultTopicPathTmp =
String.format(TOPIC_FORMAT, pipelineOptions.getProject(),
createTopicName(description));
+ System.out.println(" >>> signal topic path:" + resultTopicPathTmp);
Review comment:
Let's not write to stdout.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 102615)
Time Spent: 50m (was: 40m)
> [SQL] Add a DLQ support for Pubsub tables
> -----------------------------------------
>
> Key: BEAM-4199
> URL: https://issues.apache.org/jira/browse/BEAM-4199
> Project: Beam
> Issue Type: Improvement
> Components: dsl-sql
> Reporter: Anton Kedin
> Assignee: Anton Kedin
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Currently we crash the pipeline if there's any error processing the message
> from the pubsub, including if it has incorrect JSON format, like missing
> fields etc.
> Correct solution would be for the user to specify a way to handle the errors,
> and ideally point to a dead-letter-queue where Beam should send the messages
> it could not process.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
