[
https://issues.apache.org/jira/browse/BEAM-4277?focusedWorklogId=102646&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-102646
]
ASF GitHub Bot logged work on BEAM-4277:
----------------------------------------
Author: ASF GitHub Bot
Created on: 16/May/18 20:43
Start Date: 16/May/18 20:43
Worklog Time Spent: 10m
Work Description: tgroh closed pull request #5340: [BEAM-4277] Adding
unshaded jars used by Dataflow to poms.
URL: https://github.com/apache/beam/pull/5340
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/runners/core-construction-java/pom.xml
b/runners/core-construction-java/pom.xml
index db22d972fcf..a4ec7726e31 100644
--- a/runners/core-construction-java/pom.xml
+++ b/runners/core-construction-java/pom.xml
@@ -50,6 +50,23 @@
</systemPropertyVariables>
</configuration>
</plugin>
+ <!-- builds unshaded JARs used by Cloud Dataflow -->
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-jar-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>build-unshaded-jar</id>
+ <phase>package</phase>
+ <goals>
+ <goal>jar</goal>
+ </goals>
+ <configuration>
+ <classifier>unshaded</classifier>
+ </configuration>
+ </execution>
+ </executions>
+ </plugin>
</plugins>
</build>
diff --git a/runners/direct-java/pom.xml b/runners/direct-java/pom.xml
index e40e4b35fa7..0613a0a863f 100644
--- a/runners/direct-java/pom.xml
+++ b/runners/direct-java/pom.xml
@@ -125,6 +125,23 @@
</execution>
</executions>
</plugin>
+ <!-- builds unshaded JARs used by Cloud Dataflow -->
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-jar-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>build-unshaded-jar</id>
+ <phase>package</phase>
+ <goals>
+ <goal>jar</goal>
+ </goals>
+ <configuration>
+ <classifier>unshaded</classifier>
+ </configuration>
+ </execution>
+ </executions>
+ </plugin>
</plugins>
</pluginManagement>
diff --git a/runners/local-java/pom.xml b/runners/local-java/pom.xml
index b9b803835a0..d2ddb64f01b 100644
--- a/runners/local-java/pom.xml
+++ b/runners/local-java/pom.xml
@@ -32,6 +32,28 @@
<packaging>jar</packaging>
+ <build>
+ <plugins>
+ <!-- builds unshaded JARs used by Cloud Dataflow -->
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-jar-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>build-unshaded-jar</id>
+ <phase>package</phase>
+ <goals>
+ <goal>jar</goal>
+ </goals>
+ <configuration>
+ <classifier>unshaded</classifier>
+ </configuration>
+ </execution>
+ </executions>
+ </plugin>
+ </plugins>
+ </build>
+
<dependencies>
<!-- The Local Java Core artifact should carefully manage the classes made
available by this
dependency. The Java SDK should be used to provide common utilities (e.g.
Coder, WindowedValue)
diff --git a/sdks/java/extensions/protobuf/pom.xml
b/sdks/java/extensions/protobuf/pom.xml
index dea7b1524fb..057ed527880 100644
--- a/sdks/java/extensions/protobuf/pom.xml
+++ b/sdks/java/extensions/protobuf/pom.xml
@@ -54,6 +54,24 @@
<groupId>org.jacoco</groupId>
<artifactId>jacoco-maven-plugin</artifactId>
</plugin>
+
+ <!-- builds unshaded JARs used by Cloud Dataflow -->
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-jar-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>build-unshaded-jar</id>
+ <phase>package</phase>
+ <goals>
+ <goal>jar</goal>
+ </goals>
+ <configuration>
+ <classifier>unshaded</classifier>
+ </configuration>
+ </execution>
+ </executions>
+ </plugin>
</plugins>
</build>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 102646)
Time Spent: 1h (was: 50m)
> Adding unshaded jars to poms for Dataflow.
> ------------------------------------------
>
> Key: BEAM-4277
> URL: https://issues.apache.org/jira/browse/BEAM-4277
> Project: Beam
> Issue Type: Improvement
> Components: build-system
> Reporter: Daniel Oliveira
> Assignee: Daniel Oliveira
> Priority: Minor
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Dataflow needs some unshaded jars to be generated. Gradle already supports
> this but the pom files are still in use in some places as of filing this bug,
> and need to be updated.
> The relevant poms are:
> runners/core-construction-java/pom.xml
> runners/direct-java/pom.xml
> runners/local-java/pom.xml
> sdks/java/extensions/protobuf/pom.xml
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
