This is an automated email from the ASF dual-hosted git repository.
pabloem pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/beam.git
The following commit(s) were added to refs/heads/master by this push:
new c3c2ffd Fixing incorrect assert in dependency_test.py
c3c2ffd is described below
commit c3c2ffdce7a4da2cf65f47ff8cb01f30f423170a
Author: Daniel Oliveira <[email protected]>
AuthorDate: Tue May 8 15:01:10 2018 -0700
Fixing incorrect assert in dependency_test.py
Test uses assertTrue when it should be assertEqual. As it is now it will
always evaluate to true.
---
sdks/python/apache_beam/runners/dataflow/internal/dependency_test.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/sdks/python/apache_beam/runners/dataflow/internal/dependency_test.py
b/sdks/python/apache_beam/runners/dataflow/internal/dependency_test.py
index 585cd23..a3182a2 100644
--- a/sdks/python/apache_beam/runners/dataflow/internal/dependency_test.py
+++ b/sdks/python/apache_beam/runners/dataflow/internal/dependency_test.py
@@ -345,7 +345,7 @@ class SetupTest(unittest.TestCase):
options,
temp_dir=self.make_temp_dir())
- self.assertTrue(len(staged_resources), 2)
+ self.assertEqual(len(staged_resources), 2)
self.assertEqual(staged_resources[0], names.DATAFLOW_SDK_TARBALL_FILE)
# Exact name depends on the version of the SDK.
self.assertTrue(staged_resources[1].endswith('whl'))
--
To stop receiving notification emails like this one, please contact
[email protected].
