[
https://issues.apache.org/jira/browse/BEAM-4009?focusedWorklogId=102675&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-102675
]
ASF GitHub Bot logged work on BEAM-4009:
----------------------------------------
Author: ASF GitHub Bot
Created on: 16/May/18 21:43
Start Date: 16/May/18 21:43
Worklog Time Spent: 10m
Work Description: RobbeSneyders commented on a change in pull request
#5387: [BEAM-4009] Futurize unpackaged files
URL: https://github.com/apache/beam/pull/5387#discussion_r188781540
##########
File path: sdks/python/apache_beam/pvalue.py
##########
@@ -261,7 +266,7 @@ class TaggedOutput(object):
"""
def __init__(self, tag, value):
- if not isinstance(tag, string_types):
+ if not isinstance(tag, (bytes, unicode)):
Review comment:
This is not equivalent to six.string_types.
This should be (str, unicode).
See https://pythonhosted.org/six/#six.string_types
On Python 2, bytes is an alias for str, but on Python 3 this will behave
differently.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 102675)
Time Spent: 0.5h (was: 20m)
> Futurize and fix python 2 compatibility for unpackaged files
> ------------------------------------------------------------
>
> Key: BEAM-4009
> URL: https://issues.apache.org/jira/browse/BEAM-4009
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Robbe
> Assignee: Matthias Feys
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
