[
https://issues.apache.org/jira/browse/BEAM-4317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Scott Wegner updated BEAM-4317:
-------------------------------
Description:
Java ErrorProne static analysis was [recently
enabled|https://github.com/apache/beam/pull/5161] in the Gradle build process,
but only as warnings. ErrorProne errors are generally useful and easy to fix.
Some work was done to [make sdks-java-core
ErrorProne-clean|https://github.com/apache/beam/pull/5319] and add enforcement.
This task is clean ErrorProne warnings and add enforcement in
{{beam-runners-reference-java}} and {{beam-runners-reference-job-server}}.
Additional context discussed on the [dev
list|https://lists.apache.org/thread.html/95aae2785c3cd728c2d3378cbdff2a7ba19caffcd4faa2049d2e2f46@%3Cdev.beam.apache.org%3E].
Fixing this issue will involve:
# Follow instructions in the [Contribution
Guide|https://beam.apache.org/contribute/] to set up a {{beam}} development
environment.
# Run the following command to compile and run ErrorProne analysis on the
project: {{./gradlew :beam-runners-reference-java:assemble
:beam-runners-reference-job-server:assemble}}
# Fix each ErrorProne warning from the {{runners/reference/}} directory.
# In {{runners/reference/java/build.gradle}} and
{{runners/reference/job-server/build.gradle}}, add {{failOnWarning: true}} to
the call the {{applyJavaNature()}}
([example|https://github.com/apache/beam/pull/5319/files#diff-9390c20635aed5f42f83b97506a87333R20]).
This starter issue is sponsored by [~swegner]. Feel free to [reach
out|https://beam.apache.org/community/contact-us/] with questions or code
review:
* JIRA: [~swegner]
* GitHub: [@swegner|https://github.com/swegner]
* Slack: [@Scott Wegner|https://s.apache.org/beam-slack-channel]
* Email: swegner at google dot com
was:
Java ErrorProne static analysis was [recently
enabled|https://github.com/apache/beam/pull/5161] in the Gradle build process,
but only as warnings. ErrorProne errors are generally useful and easy to fix.
Some work was done to [make sdks-java-core
ErrorProne-clean|https://github.com/apache/beam/pull/5319] and add enforcement.
This task is clean ErrorProne warnings and add enforcement in
{{beam-runners-local-java-core}}. Additional context discussed on the [dev
list|https://lists.apache.org/thread.html/95aae2785c3cd728c2d3378cbdff2a7ba19caffcd4faa2049d2e2f46@%3Cdev.beam.apache.org%3E].
Fixing this issue will involve:
# Follow instructions in the [Contribution
Guide|https://beam.apache.org/contribute/] to set up a {{beam}} development
environment.
# Run the following command to compile and run ErrorProne analysis on the
project: {{./gradlew :beam-runners-local-java-core}}
# Fix each ErrorProne warning from the {{runners/runners-local-java-core}}
project.
# In {{runners/runners-local-java-core/build.gradle}}, add {{failOnWarning:
true}} to the call the {{applyJavaNature()}}
([example|https://github.com/apache/beam/pull/5319/files#diff-9390c20635aed5f42f83b97506a87333R20]).
This starter issue is sponsored by [~swegner]. Feel free to [reach
out|https://beam.apache.org/community/contact-us/] with questions or code
review:
* JIRA: [~swegner]
* GitHub: [@swegner|https://github.com/swegner]
* Slack: [@Scott Wegner|https://s.apache.org/beam-slack-channel]
* Email: swegner at google dot com
> Enforce ErrorProne analysis in reference runner project
> -------------------------------------------------------
>
> Key: BEAM-4317
> URL: https://issues.apache.org/jira/browse/BEAM-4317
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-harness
> Reporter: Scott Wegner
> Priority: Minor
> Labels: errorprone, starter
>
> Java ErrorProne static analysis was [recently
> enabled|https://github.com/apache/beam/pull/5161] in the Gradle build
> process, but only as warnings. ErrorProne errors are generally useful and
> easy to fix. Some work was done to [make sdks-java-core
> ErrorProne-clean|https://github.com/apache/beam/pull/5319] and add
> enforcement. This task is clean ErrorProne warnings and add enforcement in
> {{beam-runners-reference-java}} and {{beam-runners-reference-job-server}}.
> Additional context discussed on the [dev
> list|https://lists.apache.org/thread.html/95aae2785c3cd728c2d3378cbdff2a7ba19caffcd4faa2049d2e2f46@%3Cdev.beam.apache.org%3E].
> Fixing this issue will involve:
> # Follow instructions in the [Contribution
> Guide|https://beam.apache.org/contribute/] to set up a {{beam}} development
> environment.
> # Run the following command to compile and run ErrorProne analysis on the
> project: {{./gradlew :beam-runners-reference-java:assemble
> :beam-runners-reference-job-server:assemble}}
> # Fix each ErrorProne warning from the {{runners/reference/}} directory.
> # In {{runners/reference/java/build.gradle}} and
> {{runners/reference/job-server/build.gradle}}, add {{failOnWarning: true}} to
> the call the {{applyJavaNature()}}
> ([example|https://github.com/apache/beam/pull/5319/files#diff-9390c20635aed5f42f83b97506a87333R20]).
> This starter issue is sponsored by [~swegner]. Feel free to [reach
> out|https://beam.apache.org/community/contact-us/] with questions or code
> review:
> * JIRA: [~swegner]
> * GitHub: [@swegner|https://github.com/swegner]
> * Slack: [@Scott Wegner|https://s.apache.org/beam-slack-channel]
> * Email: swegner at google dot com
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
