[
https://issues.apache.org/jira/browse/BEAM-3581?focusedWorklogId=102708&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-102708
]
ASF GitHub Bot logged work on BEAM-3581:
----------------------------------------
Author: ASF GitHub Bot
Created on: 16/May/18 23:35
Start Date: 16/May/18 23:35
Worklog Time Spent: 10m
Work Description: apilloud commented on issue #5391: [BEAM-3581] [SQL]
Use saffron.properties for charset
URL: https://github.com/apache/beam/pull/5391#issuecomment-389698404
@kennknowles @akedin
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 102708)
Time Spent: 1h 10m (was: 1h)
> [SQL] Support for Non-ASCII chars is flaky
> ------------------------------------------
>
> Key: BEAM-3581
> URL: https://issues.apache.org/jira/browse/BEAM-3581
> Project: Beam
> Issue Type: Bug
> Components: dsl-sql
> Reporter: Anton Kedin
> Assignee: Anton Kedin
> Priority: Major
> Fix For: Not applicable
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Beam SQL overrides default charset that Calcite uses and sets it to UTF16. It
> is done via system properties.
> Problem is that we do this only when it hasn't been set yet. So if system
> property has been set to ISO-8859-1 (Calcite's default), then test runs will
> fail when trying to encode characters not supported in that encoding.
> Solution:
> - because it's a system property, we don't want to force override it;
> - for the same reason we cannot set it for a specific query execution;
> - we can expose a static method on BeamSql to override these properties if
> explicitly requested;
> - affected tests will explicitly override it;
> - otherwise behavior will stay unchanged and we will respect defaults and
> user settings;
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
