[
https://issues.apache.org/jira/browse/BEAM-4352?focusedWorklogId=103400&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-103400
]
ASF GitHub Bot logged work on BEAM-4352:
----------------------------------------
Author: ASF GitHub Bot
Created on: 18/May/18 15:17
Start Date: 18/May/18 15:17
Worklog Time Spent: 10m
Work Description: iemejia closed pull request #5424: [BEAM-4352] Enforce
ErrorProne analysis in Redis IO
URL: https://github.com/apache/beam/pull/5424
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/sdks/java/io/redis/build.gradle b/sdks/java/io/redis/build.gradle
index 1c5f1f96da6..75d0f9d4cd7 100644
--- a/sdks/java/io/redis/build.gradle
+++ b/sdks/java/io/redis/build.gradle
@@ -17,13 +17,14 @@
*/
apply from: project(":").file("build_rules.gradle")
-applyJavaNature()
+applyJavaNature(failOnWarning: true)
description = "Apache Beam :: SDKs :: Java :: IO :: Redis"
ext.summary ="IO to read and write on a Redis keystore."
dependencies {
compile library.java.guava
+ compileOnly library.java.findbugs_annotations
shadow project(path: ":beam-sdks-java-core", configuration: "shadow")
shadow library.java.findbugs_jsr305
shadow "redis.clients:jedis:2.9.0"
@@ -32,4 +33,5 @@ dependencies {
testCompile library.java.slf4j_jdk14
testCompile library.java.hamcrest_core
testCompile "com.github.kstyrc:embedded-redis:0.6"
+ testCompileOnly library.java.findbugs_annotations
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 103400)
Time Spent: 20m (was: 10m)
> Enforce ErrorProne analysis in the redis IO project
> ---------------------------------------------------
>
> Key: BEAM-4352
> URL: https://issues.apache.org/jira/browse/BEAM-4352
> Project: Beam
> Issue Type: Improvement
> Components: io-java-redis
> Reporter: Scott Wegner
> Assignee: Tim Robertson
> Priority: Minor
> Labels: errorprone, starter
> Fix For: 2.5.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Java ErrorProne static analysis was [recently
> enabled|https://github.com/apache/beam/pull/5161] in the Gradle build
> process, but only as warnings. ErrorProne errors are generally useful and
> easy to fix. Some work was done to [make sdks-java-core
> ErrorProne-clean|https://github.com/apache/beam/pull/5319] and add
> enforcement. This task is clean ErrorProne warnings and add enforcement in
> {{beam-sdks-java-io-redis}}. Additional context discussed on the [dev
> list|https://lists.apache.org/thread.html/95aae2785c3cd728c2d3378cbdff2a7ba19caffcd4faa2049d2e2f46@%3Cdev.beam.apache.org%3E].
> Fixing this issue will involve:
> # Follow instructions in the [Contribution
> Guide|https://beam.apache.org/contribute/] to set up a {{beam}} development
> environment.
> # Run the following command to compile and run ErrorProne analysis on the
> project: {{./gradlew :beam-sdks-java-io-redis:assemble}}
> # Fix each ErrorProne warning from the {{sdks/java/io/redis}} project.
> # In {{sdks/java/io/redis/build.gradle}}, add {{failOnWarning: true}} to the
> call the {{applyJavaNature()}}
> ([example|https://github.com/apache/beam/pull/5319/files#diff-9390c20635aed5f42f83b97506a87333R20]).
> This starter issue is sponsored by [~swegner]. Feel free to [reach
> out|https://beam.apache.org/community/contact-us/] with questions or code
> review:
> * JIRA: [~swegner]
> * GitHub: [@swegner|https://github.com/swegner]
> * Slack: [@Scott Wegner|https://s.apache.org/beam-slack-channel]
> * Email: swegner at google dot com
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
