[
https://issues.apache.org/jira/browse/BEAM-4347?focusedWorklogId=103516&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-103516
]
ASF GitHub Bot logged work on BEAM-4347:
----------------------------------------
Author: ASF GitHub Bot
Created on: 18/May/18 18:18
Start Date: 18/May/18 18:18
Worklog Time Spent: 10m
Work Description: rangadi commented on a change in pull request #5422:
[BEAM-4347] Enforce ErrorProne analysis in kafka IO
URL: https://github.com/apache/beam/pull/5422#discussion_r189347253
##########
File path:
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaExactlyOnceSink.java
##########
@@ -563,6 +564,7 @@ void commitTxn(long lastRecordId, Counter numTransactions)
throws IOException {
* closed if it is stays in cache for more than 1 minute, i.e. not used
inside
* KafkaExactlyOnceSink DoFn for a minute.
*/
+ @SuppressWarnings("FutureReturnValueIgnored")
Review comment:
I don't see where a Future is ignored. Please leave a commit :
// TODO : rangadi : review if this is even required.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 103516)
> Enforce ErrorProne analysis in the kafka IO project
> ---------------------------------------------------
>
> Key: BEAM-4347
> URL: https://issues.apache.org/jira/browse/BEAM-4347
> Project: Beam
> Issue Type: Improvement
> Components: io-java-kafka
> Reporter: Scott Wegner
> Assignee: Tim Robertson
> Priority: Minor
> Labels: errorprone, starter
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Java ErrorProne static analysis was [recently
> enabled|https://github.com/apache/beam/pull/5161] in the Gradle build
> process, but only as warnings. ErrorProne errors are generally useful and
> easy to fix. Some work was done to [make sdks-java-core
> ErrorProne-clean|https://github.com/apache/beam/pull/5319] and add
> enforcement. This task is clean ErrorProne warnings and add enforcement in
> {{beam-sdks-java-io-kafka}}. Additional context discussed on the [dev
> list|https://lists.apache.org/thread.html/95aae2785c3cd728c2d3378cbdff2a7ba19caffcd4faa2049d2e2f46@%3Cdev.beam.apache.org%3E].
> Fixing this issue will involve:
> # Follow instructions in the [Contribution
> Guide|https://beam.apache.org/contribute/] to set up a {{beam}} development
> environment.
> # Run the following command to compile and run ErrorProne analysis on the
> project: {{./gradlew :beam-sdks-java-io-kafka:assemble}}
> # Fix each ErrorProne warning from the {{sdks/java/io/kafka}} project.
> # In {{sdks/java/io/kafka/build.gradle}}, add {{failOnWarning: true}} to the
> call the {{applyJavaNature()}}
> ([example|https://github.com/apache/beam/pull/5319/files#diff-9390c20635aed5f42f83b97506a87333R20]).
> This starter issue is sponsored by [~swegner]. Feel free to [reach
> out|https://beam.apache.org/community/contact-us/] with questions or code
> review:
> * JIRA: [~swegner]
> * GitHub: [@swegner|https://github.com/swegner]
> * Slack: [@Scott Wegner|https://s.apache.org/beam-slack-channel]
> * Email: swegner at google dot com
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
