[
https://issues.apache.org/jira/browse/BEAM-2937?focusedWorklogId=103536&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-103536
]
ASF GitHub Bot logged work on BEAM-2937:
----------------------------------------
Author: ASF GitHub Bot
Created on: 18/May/18 19:40
Start Date: 18/May/18 19:40
Worklog Time Spent: 10m
Work Description: lukecwik closed pull request #5128: [BEAM-2937] Update
Portable Combine URNs to new URNs.
URL: https://github.com/apache/beam/pull/5128
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/model/pipeline/src/main/proto/beam_runner_api.proto
b/model/pipeline/src/main/proto/beam_runner_api.proto
index 11646239b93..44e3f427887 100644
--- a/model/pipeline/src/main/proto/beam_runner_api.proto
+++ b/model/pipeline/src/main/proto/beam_runner_api.proto
@@ -245,6 +245,21 @@ message StandardPTransforms {
COMBINE_PGBKCV = 0 [(beam_urn) = "beam:transform:combine_pgbkcv:v1"];
COMBINE_MERGE_ACCUMULATORS = 1 [(beam_urn) =
"beam:transform:combine_merge_accumulators:v1"];
COMBINE_EXTRACT_OUTPUTS = 2 [(beam_urn) =
"beam:transform:combine_extract_outputs:v1"];
+
+ // Represents the Pre-Combine part of a lifted Combine Per Key, as
described
+ // in the following document:
+ //
https://s.apache.org/beam-runner-api-combine-model#heading=h.ta0g6ase8z07
+ COMBINE_PER_KEY_PRECOMBINE = 3 [(beam_urn) =
"beam:transform:combine_per_key_precombine:v1"];
+
+ // Represents the Merge Accumulators part of a lifted Combine Per Key, as
+ // described in the following document:
+ //
https://s.apache.org/beam-runner-api-combine-model#heading=h.jco9rvatld5m
+ COMBINE_PER_KEY_MERGE_ACCUMULATORS = 4 [(beam_urn) =
"beam:transform:combine_per_key_merge_accumulators:v1"];
+
+ // Represents the Extract Outputs part of a lifted Combine Per Key, as
+ // described in the following document:
+ //
https://s.apache.org/beam-runner-api-combine-model#heading=h.i9i6p8gtl6ku
+ COMBINE_PER_KEY_EXTRACT_OUTPUTS = 5 [(beam_urn) =
"beam:transform:combine_per_key_extract_outputs:v1"];
}
// Payload for all of these: ParDoPayload containing the user's SDF
enum SplittableParDoComponents {
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 103536)
Time Spent: 1.5h (was: 1h 20m)
> Fn API combiner support w/ lifting to PGBK
> ------------------------------------------
>
> Key: BEAM-2937
> URL: https://issues.apache.org/jira/browse/BEAM-2937
> Project: Beam
> Issue Type: Improvement
> Components: beam-model
> Reporter: Henning Rohde
> Assignee: Daniel Oliveira
> Priority: Major
> Labels: portability
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> The FnAPI should support this optimization. Detailed design:
> https://s.apache.org/beam-runner-api-combine-model
> Once design is ready, expand subtasks similarly to BEAM-2822.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
