[
https://issues.apache.org/jira/browse/BEAM-4365?focusedWorklogId=103839&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-103839
]
ASF GitHub Bot logged work on BEAM-4365:
----------------------------------------
Author: ASF GitHub Bot
Created on: 21/May/18 04:00
Start Date: 21/May/18 04:00
Worklog Time Spent: 10m
Work Description: kennknowles commented on issue #5433: [BEAM-4365] Make
BeamSqlExpression for operators, use it for string operators
URL: https://github.com/apache/beam/pull/5433#issuecomment-390547045
I deliberately am limiting the scope of this PR. Here are things that fit in
but I did not do:
- the tests could probably be made even more concise with `Parameterized`
- type checking should also be centralized, replacing the `accept` method,
then you don't have to test any of those methods
- there are lots of other operators but I thought that's enough work that
it should go through review first
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 103839)
Time Spent: 20m (was: 10m)
> SQL operator argument evaluation should have one place where it is managed
> --------------------------------------------------------------------------
>
> Key: BEAM-4365
> URL: https://issues.apache.org/jira/browse/BEAM-4365
> Project: Beam
> Issue Type: Bug
> Components: dsl-sql
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The way Beam SQL is factored, each operator has to explicitly ask its
> argument to be evaluated. This should be handled generically at a higher
> level. Since the language is pure and terminating, it is fine for them to
> vary, but given the simplicity of the expression language it makes sense to
> use simple call-by-value.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
