[
https://issues.apache.org/jira/browse/BEAM-3926?focusedWorklogId=105033&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-105033
]
ASF GitHub Bot logged work on BEAM-3926:
----------------------------------------
Author: ASF GitHub Bot
Created on: 23/May/18 09:13
Start Date: 23/May/18 09:13
Worklog Time Spent: 10m
Work Description: echauchot commented on issue #5437: [BEAM-3926] Add new
metrics protos based on "Defining and adding SDK Metrics" htt…
URL: https://github.com/apache/beam/pull/5437#issuecomment-391278352
@ajamato I don't know protobuf so I won't be pertinent enough to review this
I'm afraid. I think @robertwb will be much more pertinent than me. But as a
general comment from a protobuf newbie, I have the impression that the
structure is a bit complex so hard to understand/maintain. I'm sure you went
through keep-it-simple iterations but please ensure that this is not
over-design to support un-probable future use cases.
Regarding the design it made me think of some comments, I'd rather do them
in the doc. Sorry if they come a bit late.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 105033)
Time Spent: 1h 20m (was: 1h 10m)
> Support MetricsPusher in Dataflow Runner
> ----------------------------------------
>
> Key: BEAM-3926
> URL: https://issues.apache.org/jira/browse/BEAM-3926
> Project: Beam
> Issue Type: Sub-task
> Components: runner-dataflow
> Reporter: Scott Wegner
> Assignee: Pablo Estrada
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> See [relevant email
> thread|https://lists.apache.org/thread.html/2e87f0adcdf8d42317765f298e3e6fdba72917a72d4a12e71e67e4b5@%3Cdev.beam.apache.org%3E].
> From [~echauchot]:
>
> _AFAIK Dataflow being a cloud hosted engine, the related runner is very
> different from the others. It just submits a job to the cloud hosted engine.
> So, no access to metrics container etc... from the runner. So I think that
> the MetricsPusher (component responsible for merging metrics and pushing them
> to a sink backend) must not be instanciated in DataflowRunner otherwise it
> would be more a client (driver) piece of code and we will lose all the
> interest of being close to the execution engine (among other things
> instrumentation of the execution of the pipelines). I think that the
> MetricsPusher needs to be instanciated in the actual Dataflow engine._
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
