[
https://issues.apache.org/jira/browse/BEAM-4393?focusedWorklogId=105744&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-105744
]
ASF GitHub Bot logged work on BEAM-4393:
----------------------------------------
Author: ASF GitHub Bot
Created on: 24/May/18 21:49
Start Date: 24/May/18 21:49
Worklog Time Spent: 10m
Work Description: kennknowles closed pull request #5472: [BEAM-4393]:
Copy root repo's LICENSE & NOTICE into shadowJar
URL: https://github.com/apache/beam/pull/5472
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/build_rules.gradle b/build_rules.gradle
index ff070d3aaa8..c3cf20d8ee2 100644
--- a/build_rules.gradle
+++ b/build_rules.gradle
@@ -547,6 +547,10 @@ ext.applyJavaNature = {
shadowJar ({
classifier = "shaded"
mergeServiceFiles()
+ into("META-INF/") {
+ from "${rootProject.projectDir}/LICENSE"
+ from "${rootProject.projectDir}/NOTICE"
+ }
} << configuration.shadowClosure)
// Always configure the shadowTestJar classifier and merge service files.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 105744)
Time Spent: 2h (was: 1h 50m)
> Missing copyright notices for shaded packages
> ---------------------------------------------
>
> Key: BEAM-4393
> URL: https://issues.apache.org/jira/browse/BEAM-4393
> Project: Beam
> Issue Type: Improvement
> Components: build-system, sdk-java-core
> Reporter: Scott Wegner
> Assignee: Boyuan Zhang
> Priority: Major
> Fix For: 2.5.0
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> From [discussion on
> dev@|https://lists.apache.org/thread.html/6ef6630e908147ee83e1f1efd4befbda43efb2a59271c5cb49473103@%3Cdev.beam.apache.org%3E],
> it was recently discovered that we are missing copyright notices for
> packages that we are shading.
> The recommended fix from [~davor] (see linked conversation), is:
> {quote}
> I'd suggest appending this sentence to the end of the LICENSE file: "A part
> of several convenience binary distributions of this software is licensed as
> follows", followed by the full license text (including its copyright, clauses
> and disclaimer) – for each such case separately. Don't edit the NOTICE file.
> {quote}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
