[
https://issues.apache.org/jira/browse/BEAM-4317?focusedWorklogId=106146&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-106146
]
ASF GitHub Bot logged work on BEAM-4317:
----------------------------------------
Author: ASF GitHub Bot
Created on: 26/May/18 13:19
Start Date: 26/May/18 13:19
Worklog Time Spent: 10m
Work Description: iemejia closed pull request #5492: [BEAM-4317] Enforce
ErrorProne analysis in runners/reference/java
URL: https://github.com/apache/beam/pull/5492
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/runners/reference/java/build.gradle
b/runners/reference/java/build.gradle
index b5f1413ecae..904799a0b42 100644
--- a/runners/reference/java/build.gradle
+++ b/runners/reference/java/build.gradle
@@ -17,7 +17,7 @@
*/
apply from: project(":").file("build_rules.gradle")
-applyJavaNature()
+applyJavaNature(failOnWarning: true)
description = "Apache Beam :: Runners :: Reference :: Java"
ext.summary = """A Java implementation of the Beam Model which utilizes the
portability
@@ -25,10 +25,12 @@ framework to execute user-definied functions."""
dependencies {
+ compileOnly library.java.findbugs_annotations
shadow project(path: ":beam-model-pipeline", configuration: "shadow")
shadow project(path: ":beam-runners-core-construction-java", configuration:
"shadow")
shadow project(path: ":beam-sdks-java-fn-execution", configuration: "shadow")
shadow library.java.slf4j_api
+ testCompileOnly library.java.findbugs_annotations
shadowTest project(path: ":beam-runners-core-construction-java",
configuration: "shadowTest")
testCompile library.java.hamcrest_core
testCompile library.java.junit
diff --git
a/runners/reference/java/src/main/java/org/apache/beam/runners/reference/JobServicePipelineResult.java
b/runners/reference/java/src/main/java/org/apache/beam/runners/reference/JobServicePipelineResult.java
index dbc33c7e22c..b9b65018c1c 100644
---
a/runners/reference/java/src/main/java/org/apache/beam/runners/reference/JobServicePipelineResult.java
+++
b/runners/reference/java/src/main/java/org/apache/beam/runners/reference/JobServicePipelineResult.java
@@ -22,6 +22,7 @@
import java.util.concurrent.ExecutionException;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.TimeoutException;
+import javax.annotation.Nullable;
import org.apache.beam.model.jobmanagement.v1.JobApi;
import org.apache.beam.model.jobmanagement.v1.JobApi.CancelJobRequest;
import org.apache.beam.model.jobmanagement.v1.JobApi.CancelJobResponse;
@@ -64,6 +65,7 @@ public State cancel() {
return getJavaState(response.getState());
}
+ @Nullable
@Override
public State waitUntilFinish(Duration duration) {
if (duration.compareTo(Duration.millis(1)) < 1) {
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 106146)
Time Spent: 40m (was: 0.5h)
> Enforce ErrorProne analysis in reference runner project
> -------------------------------------------------------
>
> Key: BEAM-4317
> URL: https://issues.apache.org/jira/browse/BEAM-4317
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-harness
> Reporter: Scott Wegner
> Assignee: Ismaël Mejía
> Priority: Minor
> Labels: errorprone, starter
> Fix For: 2.5.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Java ErrorProne static analysis was [recently
> enabled|https://github.com/apache/beam/pull/5161] in the Gradle build
> process, but only as warnings. ErrorProne errors are generally useful and
> easy to fix. Some work was done to [make sdks-java-core
> ErrorProne-clean|https://github.com/apache/beam/pull/5319] and add
> enforcement. This task is clean ErrorProne warnings and add enforcement in
> {{beam-runners-reference-java}} and {{beam-runners-reference-job-server}}.
> Additional context discussed on the [dev
> list|https://lists.apache.org/thread.html/95aae2785c3cd728c2d3378cbdff2a7ba19caffcd4faa2049d2e2f46@%3Cdev.beam.apache.org%3E].
> Fixing this issue will involve:
> # Follow instructions in the [Contribution
> Guide|https://beam.apache.org/contribute/] to set up a {{beam}} development
> environment.
> # Run the following command to compile and run ErrorProne analysis on the
> project: {{./gradlew :beam-runners-reference-java:assemble
> :beam-runners-reference-job-server:assemble}}
> # Fix each ErrorProne warning from the {{runners/reference/}} directory.
> # In {{runners/reference/java/build.gradle}} and
> {{runners/reference/job-server/build.gradle}}, add {{failOnWarning: true}} to
> the call the {{applyJavaNature()}}
> ([example|https://github.com/apache/beam/pull/5319/files#diff-9390c20635aed5f42f83b97506a87333R20]).
> This starter issue is sponsored by [~swegner]. Feel free to [reach
> out|https://beam.apache.org/community/contact-us/] with questions or code
> review:
> * JIRA: [~swegner]
> * GitHub: [@swegner|https://github.com/swegner]
> * Slack: [@Scott Wegner|https://s.apache.org/beam-slack-channel]
> * Email: swegner at google dot com
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
