[
https://issues.apache.org/jira/browse/BEAM-3214?focusedWorklogId=106537&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-106537
]
ASF GitHub Bot logged work on BEAM-3214:
----------------------------------------
Author: ASF GitHub Bot
Created on: 29/May/18 10:10
Start Date: 29/May/18 10:10
Worklog Time Spent: 10m
Work Description: iemejia commented on a change in pull request #5499:
[BEAM-3214] Add integration test for HBaseIO.
URL: https://github.com/apache/beam/pull/5499#discussion_r191363172
##########
File path:
sdks/java/io/hbase/src/test/java/org/apache/beam/sdk/io/hbase/HBaseIOIT.java
##########
@@ -0,0 +1,176 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.beam.sdk.io.hbase;
+
+import java.io.IOException;
+import java.nio.charset.StandardCharsets;
+import org.apache.beam.sdk.io.GenerateSequence;
+import org.apache.beam.sdk.io.common.HashingFn;
+import org.apache.beam.sdk.io.common.IOTestPipelineOptions;
+import org.apache.beam.sdk.io.common.TestRow;
+import org.apache.beam.sdk.options.PipelineOptionsFactory;
+import org.apache.beam.sdk.testing.PAssert;
+import org.apache.beam.sdk.testing.TestPipeline;
+import org.apache.beam.sdk.transforms.Combine;
+import org.apache.beam.sdk.transforms.Count;
+import org.apache.beam.sdk.transforms.DoFn;
+import org.apache.beam.sdk.transforms.ParDo;
+import org.apache.beam.sdk.values.PCollection;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.HBaseConfiguration;
+import org.apache.hadoop.hbase.HColumnDescriptor;
+import org.apache.hadoop.hbase.HTableDescriptor;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.client.Admin;
+import org.apache.hadoop.hbase.client.Connection;
+import org.apache.hadoop.hbase.client.ConnectionFactory;
+import org.apache.hadoop.hbase.client.Mutation;
+import org.apache.hadoop.hbase.client.Put;
+import org.apache.hadoop.hbase.client.Result;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.junit.AfterClass;
+import org.junit.BeforeClass;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.junit.runners.JUnit4;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+
+/**
+ * A test of {@link org.apache.beam.sdk.io.hbase.HBaseIOIT} on an independent
HBase instance.
+ *
+ * <p>This test requires a running instance of HBase. Pass in connection
information using
+ * PipelineOptions:
+ * <pre>
+ *
+ * ./gradlew clean integrationTest -p sdks/java/io/hbase/
-DintegrationTestPipelineOptions='[
+ * "--hbaseServerName=1.2.3.4"]' -DintegrationTestRunner=direct
+ * --tests org.apache.beam.sdk.io.hbase.HBaseIOIT
+ *
+ * </pre>
+ *
+ */
+@RunWith(JUnit4.class)
+public class HBaseIOIT {
+ private static final Logger LOG = LoggerFactory.getLogger(HBaseIOIT.class);
+ private static int numberOfRows;
+ private static final Configuration conf = HBaseConfiguration.create();
+ private static final String TABLE_NAME = "IOTesting";
+ private static final byte[] COLUMN_FAMILY = Bytes.toBytes("TestData");
+ private static final byte[] COLUMN_HASH = Bytes.toBytes("hash");
+ private static Admin admin;
+
+ @Rule
+ public TestPipeline pipelineWrite = TestPipeline.create();
+ @Rule
+ public TestPipeline pipelineRead = TestPipeline.create();
+
+ @BeforeClass
+ public static void setup() throws IOException{
+ PipelineOptionsFactory.register(IOTestPipelineOptions.class);
+ IOTestPipelineOptions options = TestPipeline.testingPipelineOptions()
+ .as(IOTestPipelineOptions.class);
+
+ numberOfRows = options.getNumberOfRecords();
+
+ conf.setStrings("hbase.zookeeper.quorum", options.getHbaseServerName());
+ conf.setStrings("hbase.cluster.distributed", "true");
+ conf.setStrings("hbase.client.retries.number", "1");
+
+ Connection connection = ConnectionFactory.createConnection(conf);
+
+ admin = connection.getAdmin();
+ HTableDescriptor testTable = new
HTableDescriptor(TableName.valueOf(TABLE_NAME)).
+ addFamily(new HColumnDescriptor(COLUMN_FAMILY));
+ admin.createTable(testTable);
+ }
+
+ @AfterClass
+ public static void tearDown() throws IOException {
+ admin.disableTable(TableName.valueOf(TABLE_NAME));
+ admin.deleteTable(TableName.valueOf(TABLE_NAME));
+ }
+
+ /**
+ * Tests writing then reading data for a HBase database.
+ */
+ @Test
+ public void testWriteThenRead() {
+ runWrite();
+ runRead();
+ }
+
+ /**
+ * Writes the test dataset to HBase.
+ */
+ private void runWrite() {
+ pipelineWrite.apply("Generate Sequence",
GenerateSequence.from(0).to((long) numberOfRows))
+ .apply("Prepare TestRows", ParDo.of(new
TestRow.DeterministicallyConstructTestRowFn()))
+ .apply("Prepare mutations", ParDo.of(new ConstructMutations()))
+ .apply("Write to HBase",
HBaseIO.write().withConfiguration(conf).withTableId(TABLE_NAME));
+
+ pipelineWrite.run().waitUntilFinish();
+ }
+
+ /**
+ * Read the test dataset from hbase and validate its contents.
+ *
+ */
+ private void runRead() {
+ PCollection<Result> tableRows = pipelineRead.apply(
+ HBaseIO.read().withConfiguration(conf).withTableId(TABLE_NAME));
+
+ PAssert.thatSingleton(
+ tableRows.apply("Count All",
+ Count.<Result>globally())).isEqualTo((long) numberOfRows);
+
+ PCollection<String> consolidatedHashcode = tableRows
+ .apply(ParDo.of(new SelectNameFn()))
+ .apply("Hash row contents", Combine.globally(new
HashingFn()).withoutDefaults());
+
+ PAssert.that(consolidatedHashcode)
+ .containsInAnyOrder(TestRow.getExpectedHashForRowCount(numberOfRows));
+
+ pipelineRead.run().waitUntilFinish();
+ }
+
+ /**
+ * Produces test rows.
+ */
+ public static class ConstructMutations extends DoFn<TestRow, Mutation> {
Review comment:
private
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 106537)
Time Spent: 40m (was: 0.5h)
> Add an integration test for HBaseIO Read/Write transforms
> ---------------------------------------------------------
>
> Key: BEAM-3214
> URL: https://issues.apache.org/jira/browse/BEAM-3214
> Project: Beam
> Issue Type: Test
> Components: io-java-hbase
> Reporter: Chamikara Jayalath
> Assignee: Kamil Szewczyk
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> We should add an small scale integration test for HBaseIO that can be run as
> a part of 'beam_PostCommit_Java_MavenInstall' and
> 'beam_PostCommit_Java_ValidatesRunner*' Jenkins test suites.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
