[
https://issues.apache.org/jira/browse/BEAM-3214?focusedWorklogId=106617&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-106617
]
ASF GitHub Bot logged work on BEAM-3214:
----------------------------------------
Author: ASF GitHub Bot
Created on: 29/May/18 13:09
Start Date: 29/May/18 13:09
Worklog Time Spent: 10m
Work Description: iemejia commented on a change in pull request #5499:
[BEAM-3214] Add integration test for HBaseIO.
URL: https://github.com/apache/beam/pull/5499#discussion_r191416352
##########
File path: .test-infra/kubernetes/hbase/SmallITCluster/setup-all.sh
##########
@@ -0,0 +1,43 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+# This script starts HBase cluster and hbase-external service that allows to
reach cluster
+# from developer's machine. Once the cluster is working, scripts waits till
+# external cluster endpoint will be available. It prints out configuration
line that
+# should be added to /etc/hosts file in order to work with HBase cluster.
+#
+
+#!/bin/sh
+set -e
+
+kubectl create -f hbase-single-node-cluster.yml
+
+kubectl create -f hbase-single-node-cluster-for-local-dev.yml
+
+external_ip="$(kubectl get svc hbase-external -o
jsonpath='{.status.loadBalancer.ingress[0].ip}')"
+
+echo "Waiting for the HBase service to come up ........"
+while [ -z "$external_ip" ]
+do
+ sleep 10s
+ external_ip="$(kubectl get svc hbase-external -o
jsonpath='{.status.loadBalancer.ingress[0].ip}')"
+ echo "."
+done
+
+hbase_master_pod_name="$(kubectl get pods --selector=name=hbase -o
jsonpath='{.items[*].metadata.name}')"
+hbase_master_namespace="$(kubectl get pods --selector=name=hbase -o
jsonpath='{.items[*].metadata.namespace}')"
+
+echo "For local tests please add the following entry to /etc/hosts file"
+echo
${external_ip}$'\t'${hbase_master_pod_name}".hbase.${hbase_master_namespace}.svc.cluster.local"
Review comment:
SC2086: Double quote to prevent globbing and word splitting.
^-- SC2039: In POSIX sh, $'..' is undefined.
^-- SC2086: Double quote to prevent globbing and
word splitting.
Pro tip: always pass a run of shellcheck in the shell scripts for specific
issues like this.
https://www.shellcheck.net/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 106617)
Time Spent: 3.5h (was: 3h 20m)
> Add an integration test for HBaseIO Read/Write transforms
> ---------------------------------------------------------
>
> Key: BEAM-3214
> URL: https://issues.apache.org/jira/browse/BEAM-3214
> Project: Beam
> Issue Type: Test
> Components: io-java-hbase
> Reporter: Chamikara Jayalath
> Assignee: Kamil Szewczyk
> Priority: Major
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> We should add an small scale integration test for HBaseIO that can be run as
> a part of 'beam_PostCommit_Java_MavenInstall' and
> 'beam_PostCommit_Java_ValidatesRunner*' Jenkins test suites.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
