[
https://issues.apache.org/jira/browse/BEAM-3199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16494141#comment-16494141
]
Tim Robertson edited comment on BEAM-3199 at 5/29/18 7:52 PM:
--------------------------------------------------------------
This is fabulous to see. I've also been in the ES issues and a few comments.
* I see your comment about the FluentBackoff not being serializable. I'd
suggest copying the approach from [SorlIO
here|https://github.com/apache/beam/blob/master/sdks/java/io/solr/src/main/java/org/apache/beam/sdk/io/solr/SolrIO.java#L778]
which is consistent with JdbcIO.
* Repeating [~echauchot] but can we make sure that the dynamic routing for
index and document ID are included please as they are necessary for updates
(upserts to be precise)? I know type is being dropped in ES so that can go
[BEAM-3201]
* Partial update support [is about to be merged |
https://github.com/apache/beam/pull/5463] to fix [BEAM-4389] as well and is
something I know one team rely on already
* We might want to consider SolrIO v6&7 discussion [BEAM-3947] when considering
packaging as one or several modules so we are consistent.
I'll be happy to help out of course - and thanks for sharing this.
was (Author: timrobertson100):
This is fabulous to see. I've also been in the ES issues and a few comments.
* I see your comment about the FluentBackoff not being serializable. I'd
suggest copying the approach from [SorlIO
here|https://github.com/apache/beam/blob/master/sdks/java/io/solr/src/main/java/org/apache/beam/sdk/io/solr/SolrIO.java#L778]
which is consistent with JdbcIO.
* Repeating [~echauchot] but can we make sure that the dynamic routing for
index and document ID are included please as they are necessary for updates
(upserts to be precise)? I know type is being dropped in ES so that can go
[BEAM-3201]
* Partial update support [is about to be merged |
https://github.com/apache/beam/pull/5463] to fix [BEAM-4389] as well and is
something I know one team rely on already
I'll be happy to help out of course.
> Upgrade to Elasticsearch 6.x
> ----------------------------
>
> Key: BEAM-3199
> URL: https://issues.apache.org/jira/browse/BEAM-3199
> Project: Beam
> Issue Type: Improvement
> Components: io-java-elasticsearch
> Reporter: Jean-Baptiste Onofré
> Assignee: Jeroen Steggink
> Priority: Major
>
> Elasticsearch 6.x is now GA. As it's fully compatible with Elasticsearch 5.x,
> it makes sense to upgrade.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
