[
https://issues.apache.org/jira/browse/BEAM-4426?focusedWorklogId=106945&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-106945
]
ASF GitHub Bot logged work on BEAM-4426:
----------------------------------------
Author: ASF GitHub Bot
Created on: 29/May/18 23:31
Start Date: 29/May/18 23:31
Worklog Time Spent: 10m
Work Description: udim commented on a change in pull request #5504:
[BEAM-4426]: Addressed DataflowDistributionAccumulatorTest failure
URL: https://github.com/apache/beam/pull/5504#discussion_r191605397
##########
File path:
sdks/python/apache_beam/transforms/dataflow_distribution_counter_test.py
##########
@@ -71,7 +70,7 @@ def test_translate_to_histogram_with_input_0(self):
def test_translate_to_histogram_with_max_input(self):
counter = DataflowDistributionCounter()
- counter.add_input(sys.maxint)
Review comment:
FYI, sys.maxint isn't in Python 3 so we would have had to change this line
sooner or later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 106945)
Time Spent: 1h (was: 50m)
> apache_beam.transforms.dataflow_distribution_counter_test failed on Windows
> ---------------------------------------------------------------------------
>
> Key: BEAM-4426
> URL: https://issues.apache.org/jira/browse/BEAM-4426
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-harness
> Reporter: Boyuan Zhang
> Assignee: Boyuan Zhang
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> apache_beam.transforms.dataflow_distributio
> n_counter_test:DataflowDistributionAccumulatorTest.test_translate_to_histogram_with_max_input
> test_translate_to_histogram_with_max_input
> (apache_beam.transforms.dataflow_distribution_counter_test.DataflowDistributi
> onAccumulatorTest) ... FAIL
> ======================================================================
> FAIL: test_translate_to_histogram_with_max_input
> (apache_beam.transforms.dataflow_distribution_counter_test.DataflowDist
> ributionAccumulatorTest)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File
> "beam\sdks\python\apache_beam\transforms\dataflow_distribution_counter_test.py",
> li
> ne 77, in test_translate_to_histogram_with_max_input
> self.assertEquals(histogram.firstBucketOffset, 57)
> AssertionError: 29 != 57
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
