[
https://issues.apache.org/jira/browse/BEAM-4082?focusedWorklogId=107294&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-107294
]
ASF GitHub Bot logged work on BEAM-4082:
----------------------------------------
Author: ASF GitHub Bot
Created on: 30/May/18 18:11
Start Date: 30/May/18 18:11
Worklog Time Spent: 10m
Work Description: kennknowles commented on a change in pull request
#5497: [BEAM-4082] Migrate from builders in RowSqlTypes to just using Schema
builder directly
URL: https://github.com/apache/beam/pull/5497#discussion_r191864536
##########
File path:
sdks/java/nexmark/src/test/java/org/apache/beam/sdk/nexmark/model/sql/RowSizeTest.java
##########
@@ -42,20 +42,20 @@
*/
public class RowSizeTest {
- private static final Schema ROW_TYPE = RowSqlTypes.builder()
- .withTinyIntField("f_tinyint")
- .withSmallIntField("f_smallint")
- .withIntegerField("f_int")
- .withBigIntField("f_bigint")
- .withFloatField("f_float")
- .withDoubleField("f_double")
- .withDecimalField("f_decimal")
- .withBooleanField("f_boolean")
- .withTimeField("f_time")
- .withDateField("f_date")
- .withTimestampField("f_timestamp")
- .withCharField("f_char")
- .withVarcharField("f_varchar")
+ private static final Schema ROW_TYPE = Schema.builder()
+ .addByteField("f_tinyint")
+ .addInt16Field("f_smallint")
+ .addInt32Field("f_int")
+ .addInt64Field("f_bigint")
+ .addFloatField("f_float")
+ .addDoubleField("f_double")
+ .addDecimalField("f_decimal")
+ .addBooleanField("f_boolean")
+ .addField(Schema.Field.of("f_time", CalciteUtils.TIME))
+ .addField(Schema.Field.of("f_date", CalciteUtils.DATE))
+ .addDateTimeField("f_timestamp")
+ .addField(Schema.Field.of("f_char", CalciteUtils.CHAR))
+ .addField(Schema.Field.of("f_varchar", CalciteUtils.VARCHAR))
Review comment:
I was thinking the same thing but being lazy. Done now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 107294)
> remove RowSqlTypeBuilder
> ------------------------
>
> Key: BEAM-4082
> URL: https://issues.apache.org/jira/browse/BEAM-4082
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-java-core
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Quoting the PR, this should be removed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
