[
https://issues.apache.org/jira/browse/BEAM-3949?focusedWorklogId=107471&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-107471
]
ASF GitHub Bot logged work on BEAM-3949:
----------------------------------------
Author: ASF GitHub Bot
Created on: 30/May/18 23:23
Start Date: 30/May/18 23:23
Worklog Time Spent: 10m
Work Description: chamikaramj commented on a change in pull request
#5434: [BEAM-3949] IOIT's setup() and teardown() db connection attempt
sometimes fail resulting in test flakiness
URL: https://github.com/apache/beam/pull/5434#discussion_r191946930
##########
File path:
sdks/java/io/common/src/test/java/org/apache/beam/sdk/io/common/IOITHelper.java
##########
@@ -36,4 +40,54 @@ public static String getHashForRecordCount(int recordCount,
Map<Integer, String>
}
return hash;
}
+
+ /**
+ * Interface for passing method to executeWithRetry method.
+ */
+ public interface RetryFunction {
+ void run() throws Exception;
+ }
+
+ public static void executeWithRetry(RetryFunction function)
+ throws Exception {
+ int maxAttempts = 3;
+ long minDelay = 10_000;
+ executeWithRetry(maxAttempts, minDelay, function);
+ }
+
+ public static void executeWithRetry(int maxAttempts, long minDelay,
RetryFunction function)
+ throws Exception {
+ ArrayList<Exception> errorList = new ArrayList<Exception>();
+ int attempts = 0;
+ long delay = minDelay;
+
+ while (attempts < maxAttempts) {
+ try {
+ function.run();
+ return;
+ } catch (Exception e) {
+ LOG.error(
+ "Attempt #{} of {} threw an exception: {} after {} ms",
+ attempts + 1,
+ maxAttempts,
+ e.getMessage(),
+ delay);
+ errorList.add(e);
+
+ if (attempts == maxAttempts - 1) {
+ for (int i = 0; i < errorList.size(); i++) {
Review comment:
Why are we double logging these errors (we logged them before) ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 107471)
> IOIT's setup() and teardown() db connection attempt sometimes fail resulting
> in test flakiness
> ----------------------------------------------------------------------------------------------
>
> Key: BEAM-3949
> URL: https://issues.apache.org/jira/browse/BEAM-3949
> Project: Beam
> Issue Type: Sub-task
> Components: testing
> Reporter: Łukasz Gajowy
> Assignee: Kasia Kucharczyk
> Priority: Major
> Time Spent: 6h
> Remaining Estimate: 0h
>
> setup() and teardown() methods sometimes have trouble connecting database in
> Performance tests. It results in test flakiness.
> Example logs:
> [https://builds.apache.org/view/A-D/view/Beam/job/beam_PerformanceTests_HadoopInputFormat/65/console]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
