[ https://issues.apache.org/jira/browse/BEAM-4328?focusedWorklogId=107984&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-107984 ]
ASF GitHub Bot logged work on BEAM-4328: ---------------------------------------- Author: ASF GitHub Bot Created on: 01/Jun/18 05:22 Start Date: 01/Jun/18 05:22 Worklog Time Spent: 10m Work Description: lukecwik commented on a change in pull request #5467: [BEAM-4328]: beam-sdks-java-io-google-cloud-platform:test failure URL: https://github.com/apache/beam/pull/5467#discussion_r192300377 ########## File path: runners/direct-java/build.gradle ########## @@ -18,18 +18,20 @@ import groovy.json.JsonOutput +//the list used for defining include set and the set of project level dependencies +def dependOnProjects = [":beam-model-pipeline", ":beam-runners-core-construction-java", + ":beam-runners-core-java", ":beam-runners-local-java-core", + ":beam-runners-java-fn-execution", ":beam-sdks-java-fn-execution"] + apply from: project(":").file("build_rules.gradle") applyJavaNature(shadowClosure: DEFAULT_SHADOW_CLOSURE << { dependencies { include(dependency(library.java.protobuf_java)) include(dependency(library.java.protobuf_java_util)) include(dependency("io.grpc:.*")) - include(project(path: ":beam-model-pipeline", configuration: "shadow")) - include(project(path: ":beam-model-fn-execution", configuration: "shadow")) - include(project(path: ":beam-runners-core-construction-java", configuration: "shadow")) - include(project(path: ":beam-runners-core-java", configuration: "shadow")) - include(project(path: ":beam-runners-java-fn-execution", configuration: "shadow")) - include(project(path: ":beam-runners-local-java-core", configuration: "shadow")) + dependOnProjects.each { + include(project(path: it, configuration: "shadow")) + } } relocate "com.google.protobuf", getJavaRelocatedPath("com.google.protobuf") Review comment: Please address the issue where we are not relocating the classes from beam-sdks-java-fn-execution in the org.apache.beam.sdk.fn namespace and beam-runners-local-java-core is in the org.apache.beam.runners.local namespace ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 107984) Time Spent: 4h 20m (was: 4h 10m) > gradle release build failed on task > :beam-sdks-java-io-google-cloud-platform:test > --------------------------------------------------------------------------------- > > Key: BEAM-4328 > URL: https://issues.apache.org/jira/browse/BEAM-4328 > Project: Beam > Issue Type: Bug > Components: build-system > Reporter: Boyuan Zhang > Assignee: Boyuan Zhang > Priority: Major > Time Spent: 4h 20m > Remaining Estimate: 0h > > Running cmd against master branch: ./gradlew clean & ./gradlew -PisRelease > build > --no-parallel failed into task :beam-sdks-java-io-google-cloud-platform:test. > Gradle scan: > [https://scans.gradle.com/s/sjwr5mixxwen2/console-log?task=:beam-sdks-java-io-google-cloud-platform:test] > > Running ./gradlew clean && ./gradlew > :beam-sdks-java-io-google-cloud-platform:test -PisRelease > --no-parallel succeed: > [https://scans.gradle.com/s/rvf7gajba7who|https://www.google.com/url?q=https://scans.gradle.com/s/rvf7gajba7who&sa=D&source=hangouts&ust=1526598527775000&usg=AFQjCNElmRkjXFh0W-5qxPHJ1h0YMh_jgw] -- This message was sent by Atlassian JIRA (v7.6.3#76005)