[
https://issues.apache.org/jira/browse/BEAM-4406?focusedWorklogId=108336&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-108336
]
ASF GitHub Bot logged work on BEAM-4406:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Jun/18 04:33
Start Date: 03/Jun/18 04:33
Worklog Time Spent: 10m
Work Description: lukecwik closed pull request #5486: [BEAM-4406]
Updating portable Dataflow major version numbers
URL: https://github.com/apache/beam/pull/5486
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/runners/google-cloud-dataflow-java/build.gradle
b/runners/google-cloud-dataflow-java/build.gradle
index deed0902ba5..c5deb9c0a90 100644
--- a/runners/google-cloud-dataflow-java/build.gradle
+++ b/runners/google-cloud-dataflow-java/build.gradle
@@ -35,7 +35,7 @@ evaluationDependsOn(":beam-examples-java")
processResources {
filter org.apache.tools.ant.filters.ReplaceTokens, tokens: [
'dataflow.legacy_environment_major_version' : '7',
- 'dataflow.fnapi_environment_major_version' : '1',
+ 'dataflow.fnapi_environment_major_version' : '7',
'dataflow.container_version' : 'beam-master-20180601'
]
}
diff --git a/runners/google-cloud-dataflow-java/pom.xml
b/runners/google-cloud-dataflow-java/pom.xml
index 51c19f8b63c..086c6c7e1d7 100644
--- a/runners/google-cloud-dataflow-java/pom.xml
+++ b/runners/google-cloud-dataflow-java/pom.xml
@@ -34,7 +34,7 @@
<properties>
<dataflow.container_version>beam-master-20180601</dataflow.container_version>
-
<dataflow.fnapi_environment_major_version>1</dataflow.fnapi_environment_major_version>
+
<dataflow.fnapi_environment_major_version>7</dataflow.fnapi_environment_major_version>
<dataflow.legacy_environment_major_version>7</dataflow.legacy_environment_major_version>
</properties>
diff --git a/sdks/python/apache_beam/runners/dataflow/internal/apiclient.py
b/sdks/python/apache_beam/runners/dataflow/internal/apiclient.py
index 72c54a40cfe..92eefbdd815 100644
--- a/sdks/python/apache_beam/runners/dataflow/internal/apiclient.py
+++ b/sdks/python/apache_beam/runners/dataflow/internal/apiclient.py
@@ -57,7 +57,7 @@
# a job submission and is used by the service to establish what features
# are expected by the workers.
_LEGACY_ENVIRONMENT_MAJOR_VERSION = '7'
-_FNAPI_ENVIRONMENT_MAJOR_VERSION = '1'
+_FNAPI_ENVIRONMENT_MAJOR_VERSION = '7'
class Step(object):
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 108336)
Time Spent: 1h (was: 50m)
> Increment major version used by Dataflow runner for portability
> ---------------------------------------------------------------
>
> Key: BEAM-4406
> URL: https://issues.apache.org/jira/browse/BEAM-4406
> Project: Beam
> Issue Type: Bug
> Components: runner-dataflow
> Reporter: Daniel Oliveira
> Assignee: Daniel Oliveira
> Priority: Minor
> Time Spent: 1h
> Remaining Estimate: 0h
>
> The major version for portable pipelines in Java and Python is set to 1. I'd
> like to set them to 7 so they have parity with the major version of native
> pipelines.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
