[
https://issues.apache.org/jira/browse/BEAM-4310?focusedWorklogId=108546&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-108546
]
ASF GitHub Bot logged work on BEAM-4310:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Jun/18 12:36
Start Date: 04/Jun/18 12:36
Worklog Time Spent: 10m
Work Description: echauchot commented on a change in pull request #5546:
[BEAM-4310] Enforce ErrorProne analysis in runners-extensions-java-me…
URL: https://github.com/apache/beam/pull/5546#discussion_r192724910
##########
File path: runners/extensions-java/metrics/build.gradle
##########
@@ -17,18 +17,20 @@
*/
apply from: project(":").file("build_rules.gradle")
-applyJavaNature()
+applyJavaNature(failOnWarning: true)
description = "Apache Beam :: Runners :: Extensions Java :: Metrics"
ext.summary = "Beam Runners Extensions Metrics provides implementations of
runners core metrics APIs."
dependencies {
compile library.java.guava
+ compileOnly library.java.findbugs_annotations
shadow project(path: ":beam-sdks-java-core", configuration: "shadow")
shadow library.java.jackson_databind
shadow library.java.jackson_datatype_joda
- shadow library.java.findbugs_annotations
Review comment:
if I understand correctly you moved library.java.findbugs_annotations dep to
only compile and testCompile scopes instead of all the scopes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 108546)
Time Spent: 20m (was: 10m)
> Enforce ErrorProne analysis in runners-extensions-java-metrics project
> ----------------------------------------------------------------------
>
> Key: BEAM-4310
> URL: https://issues.apache.org/jira/browse/BEAM-4310
> Project: Beam
> Issue Type: Improvement
> Components: runner-extensions-metrics
> Reporter: Scott Wegner
> Assignee: Ismaël Mejía
> Priority: Minor
> Labels: errorprone, starter
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Java ErrorProne static analysis was [recently
> enabled|https://github.com/apache/beam/pull/5161] in the Gradle build
> process, but only as warnings. ErrorProne errors are generally useful and
> easy to fix. Some work was done to [make sdks-java-core
> ErrorProne-clean|https://github.com/apache/beam/pull/5319] and add
> enforcement. This task is clean ErrorProne warnings and add enforcement in
> {{beam-runners-extensions-java-metrics}}. Additional context discussed on the
> [dev
> list|https://lists.apache.org/thread.html/95aae2785c3cd728c2d3378cbdff2a7ba19caffcd4faa2049d2e2f46@%3Cdev.beam.apache.org%3E].
> Fixing this issue will involve:
> # Follow instructions in the [Contribution
> Guide|https://beam.apache.org/contribute/] to set up a {{beam}} development
> environment.
> # Run the following command to compile and run ErrorProne analysis on the
> project: {{./gradlew :beam-runners-extensions-java-metrics:assemble}}
> # Fix each ErrorProne warning from the {{runners/extensions-java/metrics}}
> project.
> # In {{runners/extensions-java/metrics/build.gradle}}, add {{failOnWarning:
> true}} to the call the {{applyJavaNature()}}
> ([example|https://github.com/apache/beam/pull/5319/files#diff-9390c20635aed5f42f83b97506a87333R20]).
> This starter issue is sponsored by [~swegner]. Feel free to [reach
> out|https://beam.apache.org/community/contact-us/] with questions or code
> review:
> * JIRA: [~swegner]
> * GitHub: [@swegner|https://github.com/swegner]
> * Slack: [@Scott Wegner|https://s.apache.org/beam-slack-channel]
> * Email: swegner at google dot com
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
