[
https://issues.apache.org/jira/browse/BEAM-4137?focusedWorklogId=108614&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-108614
]
ASF GitHub Bot logged work on BEAM-4137:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Jun/18 14:57
Start Date: 04/Jun/18 14:57
Worklog Time Spent: 10m
Work Description: lgajowy commented on a change in pull request #5548:
[BEAM-4137] Remove MongoDB specific options from common/IOTestPipelin…
URL: https://github.com/apache/beam/pull/5548#discussion_r192765517
##########
File path:
sdks/java/io/mongodb/src/test/java/org/apache/beam/sdk/io/mongodb/MongoDBIOIT.java
##########
@@ -57,75 +59,88 @@
* -DintegrationTestRunner=direct
* </pre>
*
- * <p>Please see 'build_rules.gradle' file for instructions regarding
- * running this test using Beam performance testing framework.</p>
+ * <p>Please see 'build_rules.gradle' file for instructions regarding running
this test using Beam
+ * performance testing framework.
*/
@RunWith(JUnit4.class)
public class MongoDBIOIT {
- private static final Map<Integer, String> EXPECTED_HASHES = ImmutableMap.of(
- 1000, "75a0d5803418444e76ae5b421662764c",
- 100_000, "3bc762dc1c291904e3c7f577774c6276",
- 10_000_000, "e5e0503902018c83e8c8977ef437feba"
- );
+ /** MongoDBIOIT options. */
+ public interface MongoDBPipelineOptions extends IOTestPipelineOptions {
+ /* MongoDB */
Review comment:
I think we can delete this comment because there are only MongoDB related
options
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 108614)
Time Spent: 1h 20m (was: 1h 10m)
> Split IOTestPipelineOptions to multiple, test-specific files
> ------------------------------------------------------------
>
> Key: BEAM-4137
> URL: https://issues.apache.org/jira/browse/BEAM-4137
> Project: Beam
> Issue Type: Improvement
> Components: testing
> Reporter: Łukasz Gajowy
> Assignee: Łukasz Gajowy
> Priority: Minor
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Currently we have one big IOTestPipelineOptions interface that is used in
> many IOITs. It contains test specific options that should rather be located
> next to testing classes, not in a generic file. Let's split this.
> Additionally, besides separation of concerns, this will allow adding
> test-specific @Default and @Required annotations and validate the options
> better.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
