[
https://issues.apache.org/jira/browse/BEAM-4447?focusedWorklogId=108628&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-108628
]
ASF GitHub Bot logged work on BEAM-4447:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Jun/18 15:28
Start Date: 04/Jun/18 15:28
Worklog Time Spent: 10m
Work Description: lukecwik closed pull request #5541: [BEAM-4447] Move
assert_that's new keyword argument to the end
URL: https://github.com/apache/beam/pull/5541
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/sdks/python/apache_beam/testing/util.py
b/sdks/python/apache_beam/testing/util.py
index 26c54c6b80b..c518ed433b9 100644
--- a/sdks/python/apache_beam/testing/util.py
+++ b/sdks/python/apache_beam/testing/util.py
@@ -125,8 +125,8 @@ def _empty(actual):
return _empty
-def assert_that(actual, matcher, use_global_window=True,
- label='assert_that', reify_windows=False):
+def assert_that(actual, matcher, label='assert_that',
+ reify_windows=False, use_global_window=True):
"""A PTransform that checks a PCollection has an expected value.
Note that assert_that should be used only for testing pipelines since the
@@ -139,9 +139,9 @@ def assert_that(actual, matcher, use_global_window=True,
expectations and raises BeamAssertException if they are not met.
label: Optional string label. This is needed in case several assert_that
transforms are introduced in the same pipeline.
- use_global_windows: If False, matcher is passed a dictionary of
- (k, v) = (window, elements in the window).
reify_windows: If True, matcher is passed a list of TestWindowedValue.
+ use_global_window: If False, matcher is passed a dictionary of
+ (k, v) = (window, elements in the window).
Returns:
Ignored.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 108628)
Time Spent: 20m (was: 10m)
> Python SDK assert_that keyword argument order change
> ----------------------------------------------------
>
> Key: BEAM-4447
> URL: https://issues.apache.org/jira/browse/BEAM-4447
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core, testing
> Reporter: Luke Cwik
> Assignee: María GH
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> [https://github.com/apache/beam/pull/5279] changed the argument order for
> assert_that which was caught when importing the Apache Beam codebase
> internally into Google.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
